Re: [quicwg/base-drafts] Update draft-ietf-quic-transport.md (#3693)

ianswett <notifications@github.com> Mon, 25 May 2020 18:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 493BD3A0F1B for <quic-issues@ietfa.amsl.com>; Mon, 25 May 2020 11:29:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.099
X-Spam-Level:
X-Spam-Status: No, score=-3.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qqo3ZXl7x2bK for <quic-issues@ietfa.amsl.com>; Mon, 25 May 2020 11:29:33 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 669933A0F19 for <quic-issues@ietf.org>; Mon, 25 May 2020 11:29:33 -0700 (PDT)
Received: from github-lowworker-9d2806a.ash1-iad.github.net (github-lowworker-9d2806a.ash1-iad.github.net [10.56.102.50]) by smtp.github.com (Postfix) with ESMTP id 4583B5204D5 for <quic-issues@ietf.org>; Mon, 25 May 2020 11:29:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590431372; bh=Kb9fJRTdr97qxwkzID2MX5UCZEbxdP3kHY128eXPBt0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bJmMHJGF6KCdXtudLIRuhK8gEU+2c6LRbKf3nKnaWujK82XQCHjYRx00ZxMfX9Tov kHlug1cLeErri7b48CbwKSBXupleiuzLdc8Po/UfxcVFIFGL30dSmWN5h2T6TBzMih cS/Lz1nfqJPK+Asc6w4cVM6HeljNJJCMu66WQk5s=
Date: Mon, 25 May 2020 11:29:32 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6LF36DC2RIFSKO3N5427XYZEVBNHHCKNQYNU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3693/review/417836536@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3693@github.com>
References: <quicwg/base-drafts/pull/3693@github.com>
Subject: Re: [quicwg/base-drafts] Update draft-ietf-quic-transport.md (#3693)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ecc0e8c34a51_72fa3fc3702cd968234090"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/EtmsSixiwDEGkuusuS5VzLLfz3k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 25 May 2020 18:29:36 -0000

@ianswett commented on this pull request.

Thanks for updating this.  I'm worried there are some unintended changes in this PR, I've found a few so far.

> @@ -3797,17 +3797,23 @@ later time in the connection.
 The QUIC packet size includes the QUIC header and protected payload, but not the
 UDP or IP header.
 
+QUIC defines the minimum QUIC packet size as at least 1280 bytes.

```suggestion
QUIC depends upon a minimum packet size as at least 1280 bytes.
```

>  A client MUST expand the payload of all UDP datagrams carrying Initial packets
-to at least 1200 bytes, by adding PADDING frames to the Initial packet or by
+to at least the minimum QUIC packet size, by adding PADDING frames to the Initial packet or by

Keep this as 1200 bytes.

```suggestion
to at least 1200 bytes, by adding PADDING frames to the Initial packet or by
```

>  In the absence of these mechanisms, QUIC endpoints SHOULD NOT send IP packets
-larger than 1280 bytes. Assuming the minimum IP header size, this results in a
-QUIC maximum packet size of 1232 bytes for IPv6 and 1252 bytes for IPv4. A QUIC
-implementation MAY be more conservative in computing the QUIC maximum packet
-size to allow for unknown tunnel overheads or IP header options/extensions.
+larger than the minimum QUIC packet size. 
+
+All QUIC
+packets (except for PMTUD/DPLPMTUD probe packets) SHOULD be sized to fit within the
+maximum packet size to avoid the packet being fragmented or dropped
+{{?RFC8085}}.
+
+If a QUIC endpoint determines that the PMTU between any pair of local and remote
+IP addresses has fallen below the minimum QUIC packet size, it MUST immediately 

Please keep the existing wording of "smallest allowed maximum packet size", since that's very different from the minimum QUIC packet size.

```suggestion
IP addresses has fallen below the smallest allowed maximum packet size, it MUST immediately 
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3693#pullrequestreview-417836536