Re: [quicwg/base-drafts] Grease HTTP error codes (#3360)

Jana Iyengar <notifications@github.com> Tue, 21 January 2020 00:26 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D6AF1120831 for <quic-issues@ietfa.amsl.com>; Mon, 20 Jan 2020 16:26:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HAuO9T2HNvmf for <quic-issues@ietfa.amsl.com>; Mon, 20 Jan 2020 16:26:07 -0800 (PST)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 75498120801 for <quic-issues@ietf.org>; Mon, 20 Jan 2020 16:26:07 -0800 (PST)
Date: Mon, 20 Jan 2020 16:26:06 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579566366; bh=u6EYD+gT+5uPJvjiqaGq4nCXMBKO1Q6YkK8C/in7cD8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=pI3AajkWjBJiOKSl1Oe86Hw/UVWc3EAiiM9lKKe6ifYcT91kBFMdcOUSuyk+uwezA rB1ZaOpBybl7Stum6g4Y0qTXA648eEV/cqhte/07KZR5RTMBUODMhPK54zYpU/tq3V z/Z/n+P/T58ALDwXeWtu490CUSFHed7/fyiePTrM=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2STFQCGV7ANAOFIKF4GN3Z5EVBNHHCBYJK2Q@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3360/review/345580886@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3360@github.com>
References: <quicwg/base-drafts/pull/3360@github.com>
Subject: Re: [quicwg/base-drafts] Grease HTTP error codes (#3360)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e26451e9d08b_19b43fc1016cd96c237563"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/F0vqMavq2W2NqjmKlYScLFV8kqY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jan 2020 00:26:09 -0000

janaiyengar commented on this pull request.



> @@ -925,7 +925,9 @@ transferred. Endpoints MUST NOT consider these streams to have any meaning upon
 receipt.
 
 The payload and length of the stream are selected in any manner the
-implementation chooses.
+implementation chooses.  Implementations MAY terminate these streams cleanly,
+or MAY abruptly terminate them with an error code of the implementation's
+choice, including reserved error codes ({{http-error-codes}}).

This allows error codes here that might tear down the entire connection – did you mean to allow that?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3360#pullrequestreview-345580886