Re: [quicwg/base-drafts] Pseudocode fix: Data should be sent on loss-threshold timer (#2604)

Jana Iyengar <notifications@github.com> Wed, 10 April 2019 20:40 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3CE091203F2 for <quic-issues@ietfa.amsl.com>; Wed, 10 Apr 2019 13:40:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3
X-Spam-Level:
X-Spam-Status: No, score=-3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rpAEYqGbc4ek for <quic-issues@ietfa.amsl.com>; Wed, 10 Apr 2019 13:40:30 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 619EF12033B for <quic-issues@ietf.org>; Wed, 10 Apr 2019 13:40:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=eZE8wAqQDAJ/8RrYsUJeQSy8Kjs=; b=pjBqr/WsupoJG7LL 3xJPnDzt7E+3HBKj/rOBY0WyBnPUVwl2TkOgI2kYYSEPVgpRiwZzcE9Da8F7RfYS lxKXwiOd0tVrrQ275P0uR7tezkFZNm93ORsGNdicqCQgFCtkhqQYrCx9pG7CJaIF Ep5Kve0j/fjvVKoj/sH7DXVQrBw=
Received: by filter0879p1las1.sendgrid.net with SMTP id filter0879p1las1-26233-5CAE54BD-26 2019-04-10 20:40:29.718887019 +0000 UTC m=+147860.241317530
Received: from github-lowworker-f6df7df.cp1-iad.github.net (unknown [192.30.252.41]) by ismtpd0025p1iad2.sendgrid.net (SG) with ESMTP id mjwKNXzrQSasXLnonE60kQ for <quic-issues@ietf.org>; Wed, 10 Apr 2019 20:40:29.671 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-f6df7df.cp1-iad.github.net (Postfix) with ESMTP id A99253E0309 for <quic-issues@ietf.org>; Wed, 10 Apr 2019 13:40:29 -0700 (PDT)
Date: Wed, 10 Apr 2019 20:40:29 +0000 (UTC)
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3fe5cc08643ffa890aa1c723c1fb71c61598f8e992cebabb873d92a169ce19b58a1d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2604/481853355@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2604@github.com>
References: <quicwg/base-drafts/issues/2604@github.com>
Subject: Re: [quicwg/base-drafts] Pseudocode fix: Data should be sent on loss-threshold timer (#2604)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cae54bda8585_32da3fb161ed45c025669a"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0RCwVBH+DYY6WqIOP6bMoCx+3GcyG1bevzqI yKvXxZ2vnxYXdXmWDYJB2mieYuuCsZZNwKkTSKq+tSgYKmQFwnaT4pEOXRnMEKI5ZoXj8p+NfGXQJL S0GKPTJJI92vTBt2+5PohbjHXQ9QxztmJTWcVKGa7muu5+3zBga9eToM7hM+ZTHBWUCOnupDlEI60M I=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/FAjOl1GgXFG756SE_PwNL-nrKro>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Apr 2019 20:40:32 -0000

Yeah I thought about this... your point is taken in the PTO case, but there is a difference between the PTO case and this case. What you suggest is exactly what quicly implements right now. Without PRR however, the sender waits for half an RTT until it is able to send out the retransmission, since it waits until inflight < cwnd before sending anything.

I'm suggesting (and this is what TCP does) that we allow _one_ packet of rtx to go through before applying the cwnd clamp. Maybe this pseduocode isn't the best, but it's what I could come up with to capture that intent.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2604#issuecomment-481853355