[quicwg/base-drafts] c904da: Pad when validating addresses
Jana Iyengar <noreply@github.com> Tue, 20 October 2020 20:13 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BC82B3A135A for <quic-issues@ietfa.amsl.com>; Tue, 20 Oct 2020 13:13:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.101
X-Spam-Level:
X-Spam-Status: No, score=-2.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uWmotN71ijZq for <quic-issues@ietfa.amsl.com>; Tue, 20 Oct 2020 13:13:33 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2D10A3A1353 for <quic-issues@ietf.org>; Tue, 20 Oct 2020 13:13:33 -0700 (PDT)
Received: from github.com (hubbernetes-node-83aef73.ac4-iad.github.net [10.52.113.55]) by smtp.github.com (Postfix) with ESMTPA id 76DF1520D4A for <quic-issues@ietf.org>; Tue, 20 Oct 2020 13:13:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1603224812; bh=QGueSgesW1Nvs9Y4CCvUsp2ropsUDFC3+QNn5J7UazA=; h=Date:From:To:Subject:From; b=M7OKh3JB1P9wU2t2PQsGSOEyCF0zKop+HopD5QwNHdA280Few0gF9jFxBB/UpW9PL dmhLtZN+ejmIdfWB0rwRc/TkeSHR0iObeCE2d33R9AvBGfNoZ+ZGqCS4cgLypUSbUU 205gHz3MF0bJF4XtHFuZVD+Z7PT726PJiqXQyyg8=
Date: Tue, 20 Oct 2020 13:13:32 -0700
From: Jana Iyengar <noreply@github.com>
To: quic-issues@ietf.org
Message-ID: <quicwg/base-drafts/push/refs/heads/master/8a665e-739a6c@github.com>
Subject: [quicwg/base-drafts] c904da: Pad when validating addresses
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-Auto-Response-Suppress: All
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/FBMcVqwpwNij5sIuapA1P6a55yc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Oct 2020 20:13:35 -0000
Branch: refs/heads/master Home: https://github.com/quicwg/base-drafts Commit: c904daf2c14d46638e1ea0669fbb821cedac0132 https://github.com/quicwg/base-drafts/commit/c904daf2c14d46638e1ea0669fbb821cedac0132 Author: Martin Thomson <mt@lowentropy.net> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M draft-ietf-quic-transport.md Log Message: ----------- Pad when validating addresses This isn't obvious, but if you are validating an address, you are also validating the path to that address. If you don't pad these packets, then you don't know that the path supports a reasonable PMTU. Require padding of datagrams that carry packets that carry PATH_CHALLENGE. This neatly solves the problem. Closes #4216. Commit: d21c32b5c77bf303553a0c2aa6c55ae56b8bb6d0 https://github.com/quicwg/base-drafts/commit/d21c32b5c77bf303553a0c2aa6c55ae56b8bb6d0 Author: Martin Thomson <mt@lowentropy.net> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M draft-ietf-quic-transport.md Log Message: ----------- A big caveat Commit: 2686b0aeb0cf854f7f3664c0cf5940bc5e5a47b2 https://github.com/quicwg/base-drafts/commit/2686b0aeb0cf854f7f3664c0cf5940bc5e5a47b2 Author: Martin Thomson <mt@lowentropy.net> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M draft-ietf-quic-transport.md Log Message: ----------- Datagrams, not packets Co-authored-by: Jana Iyengar <jri.ietf@gmail.com> Commit: b9bfce85e043a3ca7de712433415acb8eaf71d9f https://github.com/quicwg/base-drafts/commit/b9bfce85e043a3ca7de712433415acb8eaf71d9f Author: Martin Thomson <mt@lowentropy.net> Date: 2020-10-16 (Fri, 16 Oct 2020) Changed paths: M draft-ietf-quic-transport.md Log Message: ----------- Revert automated formatting of tables, wrap Visual Studio code might need to be fired, though it's possible that this change is a good one. Commit: b3ce9e647ba7e0344f852662c200c161a5030537 https://github.com/quicwg/base-drafts/commit/b3ce9e647ba7e0344f852662c200c161a5030537 Author: Martin Thomson <mt@lowentropy.net> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M draft-ietf-quic-transport.md Log Message: ----------- Pad PATH_RESPONSE too Commit: 663465c6c3679870ac476964ce79adbdd7a73d08 https://github.com/quicwg/base-drafts/commit/663465c6c3679870ac476964ce79adbdd7a73d08 Author: Martin Thomson <mt@lowentropy.net> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M draft-ietf-quic-transport.md Log Message: ----------- Tweaks Co-authored-by: ianswett <ianswett@users.noreply.github.com> Commit: 80cbb76dcb5f1873a00047ed147282682ab53df3 https://github.com/quicwg/base-drafts/commit/80cbb76dcb5f1873a00047ed147282682ab53df3 Author: Martin Thomson <mt@lowentropy.net> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M draft-ietf-quic-transport.md Log Message: ----------- Wrap; make the other a SHOULD too Commit: abde090670ad22def944702d63ecde09600bd88b https://github.com/quicwg/base-drafts/commit/abde090670ad22def944702d63ecde09600bd88b Author: Martin Thomson <mt@lowentropy.net> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M draft-ietf-quic-transport.md Log Message: ----------- Peer path validation... Commit: 1e95cb2f928835f5f932ea3ebdce2784a9b1fd0c https://github.com/quicwg/base-drafts/commit/1e95cb2f928835f5f932ea3ebdce2784a9b1fd0c Author: Martin Thomson <mt@lowentropy.net> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M draft-ietf-quic-transport.md Log Message: ----------- MUST Co-authored-by: Jana Iyengar <jri.ietf@gmail.com> Commit: 739a6cc60f2dda200181be8383691f21f0e9868e https://github.com/quicwg/base-drafts/commit/739a6cc60f2dda200181be8383691f21f0e9868e Author: Jana Iyengar <jri.ietf@gmail.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M draft-ietf-quic-transport.md Log Message: ----------- Merge pull request #4241 from quicwg/pad-path-validation Pad path validation in both directions Compare: https://github.com/quicwg/base-drafts/compare/8a665eb37d89...739a6cc60f2d
- [quicwg/base-drafts] c904da: Pad when validating … Jana Iyengar