Re: [quicwg/base-drafts] Idle timeout indicates you will timeout (#3099)

Jana Iyengar <notifications@github.com> Wed, 16 October 2019 19:11 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3100A12080C for <quic-issues@ietfa.amsl.com>; Wed, 16 Oct 2019 12:11:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xb--hn4qfiBa for <quic-issues@ietfa.amsl.com>; Wed, 16 Oct 2019 12:11:40 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1D732120824 for <quic-issues@ietf.org>; Wed, 16 Oct 2019 12:11:37 -0700 (PDT)
Date: Wed, 16 Oct 2019 12:11:36 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571253096; bh=AiCwuMACZJhxnwlff2UI/bw2QwLHH+2QZsknGSuJxyo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=of7mmNwh5dmgCkK0oG5oBposd++yBG8+D9I5iqZufpfHj3lHgteehW8fzrvnKZIwO mLN9e8mr/SN3MeRhKE/kHEKgE9c+AbKtD0tzM9jseomrikTp02U1FSY/skCBORBfIF FoxFwiWJO7g+xxaNI3v/C7L3945pLm13JXjCj8SY=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4CF3C25PBRBFH4FXN3WSV7REVBNHHB4R4NZY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3099/review/302773060@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3099@github.com>
References: <quicwg/base-drafts/pull/3099@github.com>
Subject: Re: [quicwg/base-drafts] Idle timeout indicates you will timeout (#3099)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da76b684395f_51653f86b58cd96423179e"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/FHS55H9K_8q2_M6hpz-ZnlzwV-c>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Oct 2019 19:11:42 -0000

janaiyengar commented on this pull request.



> -endpoint is only used to determine whether the connection is live at that
-endpoint.  An endpoint that sends packets near the end of the idle timeout
-period of a peer risks having those packets discarded if its peer enters the
-draining state before the packets arrive.  If a peer could timeout within a
-Probe Timeout (PTO; see Section 6.3 of {{QUIC-RECOVERY}}), it is advisable to
-test for liveness before sending any data that cannot be retried safely.  Note
-that it is likely that only applications or application protocols will
-know what information can be retried.
+Each endpoint can advertise a different idle timeout value. An idle timeout
+indicates the connection will be abandoned when the timer ends or soon
+afterwards.  If a peer advertises a smaller idle timeout value than the
+local endpoint, the local endpoint MAY choose to idle timeout after the
+shorter period advertised by the peer.  By announcing an idle timeout,
+an endpoint commits to initiating an immediate close ({{immediate-close}})
+if it abandons a connection prior to both its peers and its own idle timeout
+expiring.

I don't think I follow this sentence. What is the endpoint committing to? To closing the connection at min(local_timeout, remote_timeout)?

> -period of a peer risks having those packets discarded if its peer enters the
-draining state before the packets arrive.  If a peer could timeout within a
-Probe Timeout (PTO; see Section 6.3 of {{QUIC-RECOVERY}}), it is advisable to
-test for liveness before sending any data that cannot be retried safely.  Note
-that it is likely that only applications or application protocols will
-know what information can be retried.
+Each endpoint can advertise a different idle timeout value. An idle timeout
+indicates the connection will be abandoned when the timer ends or soon
+afterwards.  If a peer advertises a smaller idle timeout value than the
+local endpoint, the local endpoint MAY choose to idle timeout after the
+shorter period advertised by the peer.  By announcing an idle timeout,
+an endpoint commits to initiating an immediate close ({{immediate-close}})
+if it abandons a connection prior to both its peers and its own idle timeout
+expiring.
+
+An endpoint that sends packets near the end of the idle timeout period of a peer

```suggestion
An endpoint that sends packets near the end of its peer's idle timeout period
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3099#pullrequestreview-302773060