Re: [quicwg/base-drafts] Improve language on evictable entries. (#3131)

Mike Bishop <notifications@github.com> Tue, 25 February 2020 16:06 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 00AC73A0FB0 for <quic-issues@ietfa.amsl.com>; Tue, 25 Feb 2020 08:06:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.099
X-Spam-Level:
X-Spam-Status: No, score=-3.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KVQeWtB8abOu for <quic-issues@ietfa.amsl.com>; Tue, 25 Feb 2020 08:06:54 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 744E63A0FDD for <quic-issues@ietf.org>; Tue, 25 Feb 2020 08:06:54 -0800 (PST)
Received: from github-lowworker-b19c547.va3-iad.github.net (github-lowworker-b19c547.va3-iad.github.net [10.48.17.66]) by smtp.github.com (Postfix) with ESMTP id 8612B2C2260 for <quic-issues@ietf.org>; Tue, 25 Feb 2020 08:06:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582646813; bh=iv61Txe/EDrcaM+7STCKMk0UQjGgFZgWrGUPy6nZ0wg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0/Kk+JcJt/e4vaOG2iUAKWNUEm4zpBQkfNrcK95SgCOpeUOfSp6dGoQDcl8GrlEjO 2bPzVEpksPmldxS8NaKP8/m92zQ+mvD/Dok6QRIu7JEL1iVsFrf05Pi2kBn6L3opsZ teVF70wTbMm10gpmamIw0upbwX/03pCSqsjq/Rnw=
Date: Tue, 25 Feb 2020 08:06:53 -0800
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5J7KTTHWRF2ZJPGK54MJ4J3EVBNHHB45IJ64@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3131/review/364266758@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3131@github.com>
References: <quicwg/base-drafts/pull/3131@github.com>
Subject: Re: [quicwg/base-drafts] Improve language on evictable entries. (#3131)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e55461d759df_18ae3ff8db2cd96826345"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/FNmIIfXlwt1USiNCHSIPsHgm1Mw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Feb 2020 16:07:03 -0000

MikeBishop commented on this pull request.



>  ### Limits on Dynamic Table Insertions {#blocked-insertion}
 
 Inserting entries into the dynamic table might not be possible if the table
 contains entries which cannot be evicted.
 
 A dynamic table entry cannot be evicted immediately after insertion, even if it
 has never been referenced. Once the insertion of a dynamic table entry has been
-acknowledged and there are no outstanding unacknowledged references to the
-entry, the entry becomes evictable.
+acknowledged and there are no outstanding references to the entry in
+unacknowledged header blocks, the entry becomes evictable.  Note that
+unacknowledged references on the encoder stream do not preclude the eviction of

This might be a (very old!) holdover from when inserts weren't always on a single stream.  In that case, you might have an unacknowledged insert that depended on another entry for the field name.  But as they *are* on a single stream, the insert that causes an eviction can only arrive after the insert that has the dependency has already been processed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3131#discussion_r383977630