Re: [quicwg/base-drafts] Gorrys invariant nits (#3730)

Martin Thomson <notifications@github.com> Tue, 09 June 2020 01:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8A83E3A08FF for <quic-issues@ietfa.amsl.com>; Mon, 8 Jun 2020 18:46:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U_yHihYEn0Uv for <quic-issues@ietfa.amsl.com>; Mon, 8 Jun 2020 18:46:50 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1C8523A08E8 for <quic-issues@ietf.org>; Mon, 8 Jun 2020 18:46:50 -0700 (PDT)
Received: from github-lowworker-9bcb4a1.ac4-iad.github.net (github-lowworker-9bcb4a1.ac4-iad.github.net [10.52.25.84]) by smtp.github.com (Postfix) with ESMTP id 274172C0AAC for <quic-issues@ietf.org>; Mon, 8 Jun 2020 18:46:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1591667209; bh=6ZZ1urZQwQX2Gaoz30pLaBj7g3OCSgU5caBHnABLMHY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1XWqIrh7yIfwIVrD1Oq65amx45hoiM1PO5N791i5eP4bqWqCvYAq0VqQyifMYyz4G 2zSrC2Xlx74HIoor1D2zhIGzTLvNH0fH7mpPq/QVoh9U9vDOgAsjv5OK9yl8Gzuqnp WIozmi21DFPL1dE1mNwhyIIqw6RWsWpq+V8TUNas=
Date: Mon, 08 Jun 2020 18:46:49 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZU3AUFNKFB7D2PIL545LFQTEVBNHHCLIOW54@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3730/review/426733457@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3730@github.com>
References: <quicwg/base-drafts/pull/3730@github.com>
Subject: Re: [quicwg/base-drafts] Gorrys invariant nits (#3730)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5edeea0918a6e_61e13ff051acd95c100231"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/FZ8A8Aj99WCCi0ryG33PR2c8bTM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jun 2020 01:46:52 -0000

@martinthomson commented on this pull request.



> @@ -235,11 +240,11 @@ A connection ID is an opaque field of arbitrary length.
 
 The primary function of a connection ID is to ensure that changes in addressing
 at lower protocol layers (UDP, IP, and below) don't cause packets for a QUIC
-connection to be delivered to the wrong endpoint.  The connection ID is used by
-endpoints and the intermediaries that support them to ensure that each QUIC
-packet can be delivered to the correct instance of an endpoint.  At the
-endpoint, the connection ID is used to identify which QUIC connection the packet
-is intended for.
+connection to be delivered to the wrong transport endpoint.  The connection ID

This was really trying to avoid having to pull in the definition of "endpoint" from the transport doc.  I see that I failed there.  Happy to take suggestions, like:

```suggestion
connection to be delivered to the wrong destination.  The connection ID
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3730#discussion_r437091718