Re: [quicwg/base-drafts] Fix to ECN section regarding validation (#2113)

ianswett <> Wed, 12 December 2018 10:47 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 1E534130DC6 for <>; Wed, 12 Dec 2018 02:47:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -8.056
X-Spam-Status: No, score=-8.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id KZLXH3n2-PDc for <>; Wed, 12 Dec 2018 02:47:00 -0800 (PST)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id BAA4512777C for <>; Wed, 12 Dec 2018 02:47:00 -0800 (PST)
Date: Wed, 12 Dec 2018 02:46:59 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1544611619; bh=tMSKvDFwq8uBnwsN3K9Hl9kyDsaljFiZrdXbSPNbgTY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=MkAlmPq2IlYjQ+RKAQGFZeWTumsBvYJBUL+J6h2f8x4KJLK3Ca2STprVj8l/uOx6j +xa5hl9Ckd2ZUG2FYK6/AtrOZSm5v+OArQ94DoSp8L0jrU2dOFrbXFxQNhnVlrxdf/ kKycnyAOKhkgnM+lqk5O2Aaa55vingnQ0XJBznzg=
From: ianswett <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2113/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Fix to ECN section regarding validation (#2113)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c10e723d47ae_3c3f3ffdee8d45c41603a0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Wed, 12 Dec 2018 10:47:02 -0000

ianswett commented on this pull request.

>    Not-ECT.
 If a sender receives an ACK that contains no new acknowledgments, for example
 due to reordering of the ACKs, then ECN counter comparison SHOULD NOT be
-performed. Also if sender do not have state to determine if a particular PSN
-is newly acknowledge or not, then the comparison SHOULD NOT be performed.
+performed. If the sender does not have state to determine if a particular PSN
+is newly acknowledged or not, then the comparison SHOULD NOT be performed.

I think it's supposed to be packet sequence number?  But the text always uses packet number and abbreviates it to PN, so if that's what it is, it should be changed.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: