Re: [quicwg/base-drafts] Discard 0-RTT packet state when rejected (#2300)

Kazuho Oku <notifications@github.com> Tue, 08 January 2019 05:47 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 898D9131067 for <quic-issues@ietfa.amsl.com>; Mon, 7 Jan 2019 21:47:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7q9vqey6-Mye for <quic-issues@ietfa.amsl.com>; Mon, 7 Jan 2019 21:47:01 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DEDB6129A87 for <quic-issues@ietf.org>; Mon, 7 Jan 2019 21:47:00 -0800 (PST)
Date: Mon, 07 Jan 2019 21:47:00 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546926420; bh=N4+c+1lAVCIRqPxxzpPYZpMGOQh/DtMCrrO6Pp05Qz0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=JBwiRIHhGYaVO59IYnecaK0NZ6wHyAI0I6ivay6dZq26WcSsMPrgEtILwyuxBLw7L dDMCCUeoWNqIp3Glr3rGLzB2vadrw2/l2x19sO5uJ7ue0+eNSXKsuyiuwx8Izc1SAN L8NBay9NurT678zj+bGewHn71xx8oSPhCDQmejEo=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab72723e68daf86ac69a3c144a0b95df35828964cf92cf00000001184bfb5492a169ce179f005f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2300/review/190099462@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2300@github.com>
References: <quicwg/base-drafts/pull/2300@github.com>
Subject: Re: [quicwg/base-drafts] Discard 0-RTT packet state when rejected (#2300)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c343954d7fa_7bcd3fbe5acd45bc12741b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/FshLaTTF2mJ8AZ6FfSXtbDt_W98>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jan 2019 05:47:02 -0000

kazuho commented on this pull request.



> -destroyed earlier.
+When keys for an packet number space are discarded, any in-flight packets
+sent with those keys are removed from the count of bytes in flight.  Loss
+recovery state is also discarded, so no loss events will occur for any
+in-flight packets from that space(see {{discard-initial}}).  Note that it is
+expected that keys are discarded after those packets would be declared lost,
+but Initial secrets are destroyed earlier.
+
+## Discarding 0-RTT packet state
+
+When 0-RTT is rejected, all in-flight 0-RTT packets still are removed from
+the count of bytes in flight.  Loss recovery state is also discarded, so no
+loss events will occur for any in-flight 0-RTT packets.  If a server does not
+buffer out-of-order packets and accepts 0-RTT, there is a chance of declaring
+0-RTT packets lost that were actually discarded by the server, but this is
+expected to be infrequent.

My bad. I incorrectly assumed that the text is talking about 0-RTT packets arriving late. Actually, it is talking about 0-RTT packets arriving before Initial.

I am not sure if others would have the same confusion as I had, but changing "but does not buffer out of order packets and there is reordering" to "but does not buffer 0-RTT packets arriving before Initial packets" might better clarify what is being discussed here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2300#discussion_r245883363