IETF Logo Mail Archive

Re: [quicwg/base-drafts] Replace the RequireInsertCount decoding algorithm (#2379)

afrind <notifications@github.com> Wed, 30 January 2019 02:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DA7B31310DD for <quic-issues@ietfa.amsl.com>; Tue, 29 Jan 2019 18:12:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KQ1_9-S9xJBz for <quic-issues@ietfa.amsl.com>; Tue, 29 Jan 2019 18:12:44 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7F9AA126C7E for <quic-issues@ietf.org>; Tue, 29 Jan 2019 18:12:44 -0800 (PST)
Date: Tue, 29 Jan 2019 18:12:43 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548814363; bh=XXBB2oH3mLc+NTYMoVR4BihAInXMGd5kd+YrknuCpIM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=v2j/q+FGK7BYVQBBZj0RIDErL+D000qRzk88IQTHD9mQmXgCUV+z+D2bXvViyZ2P8 36slS4Ub0PTVd3RvMw/IOu+vkdRWZV5Cs3Zl2d8V5F2xoFvpzEAwfB7nPRucD1nDWe i+AGJNV9ta4psryE1thTmMQm7/z8BWebR5EjcF8U=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe123d865193652429dc6ecdd20a6c79506201b7d92cf000000011868ca1b92a169ce180fea0e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2379/c458784398@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2379@github.com>
References: <quicwg/base-drafts/pull/2379@github.com>
Subject: Re: [quicwg/base-drafts] Replace the RequireInsertCount decoding algorithm (#2379)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c51081b7ef54_52273fb6c3ed45b869567"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Fy918XICBqzSuiScH1ms7z_QfPM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jan 2019 02:12:46 -0000

This algorithm doesn't explicitly validate that the wire value is <= 2 * MaxEntries, and if it receives a larger value, may produce a value in the future.  

I can add an explicit error check to the algorithm, or add normative text that this is an error, or both.  I'm inclined to add it to the code?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2379#issuecomment-458784398

v2.23.0 | Report a Bug | By Email