[quicwg/base-drafts] loss recovery description mixes variables depending on the packet number space and packet numbers independent of it (#2405)

Marten Seemann <notifications@github.com> Mon, 04 February 2019 06:47 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2AB6A1294FA for <quic-issues@ietfa.amsl.com>; Sun, 3 Feb 2019 22:47:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pQhQQ59VwRn9 for <quic-issues@ietfa.amsl.com>; Sun, 3 Feb 2019 22:47:44 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ECD6A126CC7 for <quic-issues@ietf.org>; Sun, 3 Feb 2019 22:47:43 -0800 (PST)
Date: Sun, 03 Feb 2019 22:47:42 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549262862; bh=6zv+3Ro8n47ExflKZAMAPPNdTa1IW81N5j65ENzWoJ0=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=MoLKZEQsxMIz+pCBMWRAF/cA9iRSg0LSPFBLvkrK26ALj+aa0zSxx1I6C1rnVVDJT chc04BC4D0O4RvjefzPkM556jl+2ntwg02fH2ODD/vCmF51C/HgdHtpf46gFrkHnO3 NJjAsYfMiUL5y/so9Mn9ZbAdN+qvfkEeC+FdLhD8=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0ae86afeacbc98d2d58e36db686eb233f1b9260a92cf00000001186fa20e92a169ce1836223d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2405@github.com>
Subject: [quicwg/base-drafts] loss recovery description mixes variables depending on the packet number space and packet numbers independent of it (#2405)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c57e00ea31c2_339e3feed5ed45b41939c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/G0CxtWOsrFi4G8EPH185Ezby1FU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Feb 2019 06:47:46 -0000

[Section 6.5.2](https://quicwg.org/base-drafts/draft-ietf-quic-recovery.html#rfc.section.6.5.2) lists the variables used by the loss recovery algorithm. 
Some of these variables are independent of the packet number space, e.g. `crypto_count`, `*rtt*.`
Other variables apply per packet number space, and we say so explicitly, e.g. `largest_acked_packet`.
Then there are a lot of variables that should be applied per packet number space, but we never say so explicitly, e.g. `sent_packets`, `loss_time`, etc.

The same applies to the pseudo code itself, for example `DetectLostPackets` uses both variables that only apply to one packet number space as well as variables that apply independent of the packet number space.

One way to resolve this would be to index the variables by their respective packet number space.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2405