Re: [quicwg/base-drafts] QPACK: Encode Largest Reference modulo MaxEntries (#1763)
Dmitri Tikhonov <notifications@github.com> Fri, 28 September 2018 15:48 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8F749130E44 for <quic-issues@ietfa.amsl.com>; Fri, 28 Sep 2018 08:48:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.456
X-Spam-Level:
X-Spam-Status: No, score=-3.456 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sGPB6zapnGSh for <quic-issues@ietfa.amsl.com>; Fri, 28 Sep 2018 08:48:34 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ACDA2130E42 for <quic-issues@ietf.org>; Fri, 28 Sep 2018 08:48:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=TkcNExM4mnhFVo6NWNAloWeynPs=; b=WeLG4j8ZteeewbL1 KuGhqfZ69Ja6bb2LqnNghfeEYgi3wA30lBAr7SeGgWWvtcANmvifNCMo8NCt+CUq yLzty3U8AS14Z5mO7WJhJaVu4esbCXDUQSbXPQpqgkyH/Eibub3dEC6wMjYzM1kE wbYTeUxQUfyDtnWe9JZAIw0TWXI=
Received: by filter1535p1mdw1.sendgrid.net with SMTP id filter1535p1mdw1-15711-5BAE4D51-34 2018-09-28 15:48:33.55849111 +0000 UTC m=+250624.243508787
Received: from github-lowworker-dcd58f3.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0011p1iad2.sendgrid.net (SG) with ESMTP id 4LFSZ9BXQnOJT_D8yoArFg for <quic-issues@ietf.org>; Fri, 28 Sep 2018 15:48:33.518 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-dcd58f3.cp1-iad.github.net (Postfix) with ESMTP id 7DD04240D80 for <quic-issues@ietf.org>; Fri, 28 Sep 2018 08:48:33 -0700 (PDT)
Date: Fri, 28 Sep 2018 15:48:33 +0000
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb457f6fef9e37ce8c9c54c8e63f71aadcc5e225c92cf0000000117c60f5192a169ce1586350b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1763/review/159918926@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1763@github.com>
References: <quicwg/base-drafts/pull/1763@github.com>
Subject: Re: [quicwg/base-drafts] QPACK: Encode Largest Reference modulo MaxEntries (#1763)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bae4d517bb11_2eaa3fbc2b8d45c4752ba"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1fNiX/pjY+sG4PO1Ke8ACuk3yiuoWwVqTIkv YOvJd2EzX6Uv9OOGN+Kdin+jn5cmiSA/c+Y56Wy8T56tfZKQ5LKGm+dGNDp3kmBCqcn/6vnUSFw0v1 IxC+2UZAlnDP+CZL7TFVELTj4+2pVssNpuJtB3F+rPZ7XXIS62JUn8E5wVsje2nJ1MbpJQadFAGnVA c=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/G9IBPS2CxJI8GLOTAv1CVN4wuAM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Sep 2018 15:48:37 -0000
dtikhonov commented on this pull request. > @@ -149,7 +149,9 @@ peer's SETTINGS frame. Before a new entry is added to the dynamic table, entries are evicted from the end of the dynamic table until the size of the dynamic table is less than or -equal to (maximum size - new entry size) or until the table is empty. +equal to (maximum size - new entry size) or until the table is empty. The +encoder MUST NOT evict a dynamic table entry unless it has first been I see. I usually squash my commits when merging from a branch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1763#discussion_r221299003
- [quicwg/base-drafts] QPACK: Encode Largest Refere… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… MikkelFJ
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Kazuho Oku
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Kazuho Oku
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Kazuho Oku
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… MikkelFJ
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… MikkelFJ
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… MikkelFJ
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Kazuho Oku
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Mike Bishop
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Mike Bishop
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… afrind
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Bence Béky
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Bence Béky
- Re: [quicwg/base-drafts] QPACK: Encode Largest Re… Bence Béky