Re: [quicwg/base-drafts] Allow server to enforce port-Retry packet numbering (#3989)

Mike Bishop <notifications@github.com> Tue, 11 August 2020 15:54 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 149453A0475 for <quic-issues@ietfa.amsl.com>; Tue, 11 Aug 2020 08:54:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hvxzfhGO3aet for <quic-issues@ietfa.amsl.com>; Tue, 11 Aug 2020 08:54:40 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ABE2E3A0407 for <quic-issues@ietf.org>; Tue, 11 Aug 2020 08:54:40 -0700 (PDT)
Received: from github-lowworker-39ac79b.ac4-iad.github.net (github-lowworker-39ac79b.ac4-iad.github.net [10.52.18.15]) by smtp.github.com (Postfix) with ESMTP id B919352007C for <quic-issues@ietf.org>; Tue, 11 Aug 2020 08:54:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597161279; bh=RwO5orhXliMgJsy/iIpB9SQlKmgN1ve4X28sQPYMgJQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=PzyRdYRPMvq1r8Hv5MTc3T2SdED1+UGxb6/B7Dn16ABMZmmJ3CwO+ygimyHkO1s25 IKt4igQIpyfc/KGXN1VkJbcIb5sN91KM1sp5Sk8vgGwhKA35CEPLmNsq3cR6jILhXp SAWk58uz3tz3fbwpdXcjYJJWb97yblAkjrvr3OTI=
Date: Tue, 11 Aug 2020 08:54:39 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7QRNLZNSPXTIZ3OHF5H2QD7EVBNHHCQTDTBE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3989/672037067@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3989@github.com>
References: <quicwg/base-drafts/issues/3989@github.com>
Subject: Re: [quicwg/base-drafts] Allow server to enforce port-Retry packet numbering (#3989)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f32bf3fa9f54_7c6e16f8896e6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/G9mJS1TkvQ1mR8bV_XvWQNj-dk8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Aug 2020 15:54:42 -0000

If it's not trivial, it's verging on trivial.  The "right" way to enforce this, as Dmitri notes, is to include the client's packet number in the Retry token.  Upon receipt of any token, if it is a retry token, the server checks whether the containing packet number is less than or equal to that stored in the token.  If it's not a retry token, no check is needed.  This is completely stateless, so if packets get reordered, nothing breaks.

As to the point of modifying Initial packets, that's true.  An attacker that can modify packets can always cause the handshake to fail; this is just another way.  To use this for disruption by injecting a packet, the attacker has to observe the client's Initial, the server's Retry packet, and then fabricate an Initial with a lower packet number.  Not a high bar, but an attacker that can observe the packets in both directions and inject packets can break things in many other ways, too.

I'm comfortable with MAY enforce (which I think is already implicit in a MUST NOT) at least, if people think one more integer encoded in the token is too high a bar for a stronger recommendation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3989#issuecomment-672037067