IETF Logo Mail Archive

Re: [quicwg/base-drafts] Fix some of the nits in #3214 (#4016)

Mike Bishop <notifications@github.com> Tue, 25 August 2020 15:26 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F1E913A0FAC for <quic-issues@ietfa.amsl.com>; Tue, 25 Aug 2020 08:26:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.081
X-Spam-Level:
X-Spam-Status: No, score=0.081 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.282, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g0TNdAFz0_GI for <quic-issues@ietfa.amsl.com>; Tue, 25 Aug 2020 08:26:40 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A79163A0FD7 for <quic-issues@ietf.org>; Tue, 25 Aug 2020 08:26:38 -0700 (PDT)
Received: from github-lowworker-0f7e7fd.ash1-iad.github.net (github-lowworker-0f7e7fd.ash1-iad.github.net [10.56.110.17]) by smtp.github.com (Postfix) with ESMTP id E7AFC5E0F28 for <quic-issues@ietf.org>; Tue, 25 Aug 2020 08:26:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1598369197; bh=cUNvN/efnDSWx6xW10htw1zTPs5EwNV6S4G1UZwPBRk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=CKnzpxJ7FJf7wa3Tn/2CxUK9HpawC8gzPGgENKG7SgoNx7MlWrRUic0pYhLcnxHwB VREwSshAZDxFIxV+FY2NkpCQ/o3vhVulu1CQt2NUszTVHHBzewiP4nqu5+KifJJ0jj Fg0bD1pyrqD/ELEEKthhOplLCZt2EA8tXm/gnU4c=
Date: Tue, 25 Aug 2020 08:26:37 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7HU4M6L67OAPFGH7V5KEHK3EVBNHHCRJE2U4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4016/review/474595848@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4016@github.com>
References: <quicwg/base-drafts/pull/4016@github.com>
Subject: Re: [quicwg/base-drafts] Fix some of the nits in #3214 (#4016)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f452dadd8ea8_520719643049ce"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/GCkS_2wimEMYU9V-x2Vy5KTk4-g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Aug 2020 15:26:42 -0000

@MikeBishop commented on this pull request.



> @@ -1768,9 +1772,10 @@ completes, the client uses the transport parameters established in the
 handshake.  Not all transport parameters are remembered, as some do not apply to
 future connections or they have no effect on use of 0-RTT.
 
-The definition of new transport parameters ({{new-transport-parameters}}) MUST
-specify whether they MUST, MAY, or MUST NOT be stored for 0-RTT. A client need
-not store a transport parameter it cannot process.
+The definition of a new transport parameter ({{new-transport-parameters}}) MUST
+specify whether that storing the transport parameter for 0-RTT is mandatory,

```suggestion
specify whether storing the transport parameter for 0-RTT is mandatory,
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4016#pullrequestreview-474595848

v2.23.0 | Report a Bug | By Email