IETF Logo Mail Archive

Re: [quicwg/base-drafts] http deadlock with stream FIN choices (#1972)

Mike Bishop <notifications@github.com> Wed, 14 November 2018 20:09 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 16358130DC9 for <quic-issues@ietfa.amsl.com>; Wed, 14 Nov 2018 12:09:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AOsIxdjcvj5o for <quic-issues@ietfa.amsl.com>; Wed, 14 Nov 2018 12:09:31 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0291C1277C8 for <quic-issues@ietf.org>; Wed, 14 Nov 2018 12:09:31 -0800 (PST)
Date: Wed, 14 Nov 2018 12:09:30 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542226170; bh=sqD2uoZ+dPmGKUl77VbvZc4WtEv+CeOqfiWFh8dZ6pc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Nyb7Lc7wZUwOuL9/B2CV6ZwPj4BwGNZSEE9UuUmrTPBFOe94juNGk3JoW40B+q4NX h2mBBx2q1bavOWOeLOKrT7PGuR1SEofRRHHg6UfiUgx2BLPPD1kh8QKLveqvNv51C4 +O3wk5rG68NSkr8XVHhU9IqrbQXQZVEzNlo49QbE=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abbcb8a5f883b016d9a5eb29720ef159a85be6e51f92cf00000001180442fa92a169ce1683c825@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1972/438801077@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1972@github.com>
References: <quicwg/base-drafts/issues/1972@github.com>
Subject: Re: [quicwg/base-drafts] http deadlock with stream FIN choices (#1972)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bec80faeea9_7b7c3ff3014d45c01412a6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/GOBHqtBVNyJBdHxzU28_Jx-f7g0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Nov 2018 20:09:33 -0000

@RyanAtGoogle points out that Content-Length isn't mandatory, and when absent, end-of-stream is the only way to identify the end of the body.  So perhaps we need to be having a more granular conversation here:  You have to process headers (and discover whether you're expecting a body) without waiting for the body to arrive.

If you expect a body and the length is given, read that many bytes.  If you expect a body of unknown size, then and only then do you use end-of-stream as a signal.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1972#issuecomment-438801077

v2.34.0 | Report a Bug | By Email | System Status