Re: [quicwg/base-drafts] Cache git repo, draft references in Circle (#3009)

Mike Bishop <notifications@github.com> Mon, 09 September 2019 15:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B31DB120823 for <quic-issues@ietfa.amsl.com>; Mon, 9 Sep 2019 08:12:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id twATvAz3oAQn for <quic-issues@ietfa.amsl.com>; Mon, 9 Sep 2019 08:12:27 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D2A3A120828 for <quic-issues@ietf.org>; Mon, 9 Sep 2019 08:12:26 -0700 (PDT)
Date: Mon, 09 Sep 2019 08:12:25 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1568041945; bh=q6zfXAjq0mzqjfLWIPzWknn087mJ4CG5UAW7ZF0dB64=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=NcWoz/ejSwL+Rzr5w6eTJPNwtJWkFzSj6s9zQ+6M1OnRqmmQHXmJo3FOMZZgbeYpR QAuD1OljHuoQ27tZos3eEkNEfHoUfzUbOJgd1rlYNIzXTp8W8ZlogjpIO3bspGZnXF AWfUNmY6QwhDOoV2MY0f3hvywR209iHmA1J1wtHM=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5USW5PIB2RDOODBPV3QOWGTEVBNHHB2OXHYQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3009/c529524438@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3009@github.com>
References: <quicwg/base-drafts/pull/3009@github.com>
Subject: Re: [quicwg/base-drafts] Cache git repo, draft references in Circle (#3009)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d766bd9dc091_735e3fb0c42cd968190232"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/GPwyigrp4cYxzMtkFcZ1LXprk1E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Sep 2019 15:12:29 -0000

The important piece there are the multi-tiered keys in restore:
```
      - restore_cache:
          name: "Restoring cache - Git"
          keys:
            - v1-cache-git-{{ .Branch }}-{{ .Revision }}
            - v1-cache-git-{{ .Branch }}
            - v1-cache-git-

      - restore_cache:
          name: "Restoring cache - References"
          keys:
            - v1-cache-references-{{ epoch }}
            - v1-cache-references-
```
The revision will never match, so it picks up the most recent git repo cached for that branch.  The epoch will almost never match, so it picks up the most recent reference cache generated.  We could drop the first line of each restore_cache keys directive and get the same behavior.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3009#issuecomment-529524438