Re: [quicwg/base-drafts] DUPLICATE_PUSH push ID validation (#2681)

Mike Bishop <notifications@github.com> Thu, 09 May 2019 18:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EE684120059 for <quic-issues@ietfa.amsl.com>; Thu, 9 May 2019 11:12:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.392
X-Spam-Level:
X-Spam-Status: No, score=-1.392 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uZbZ_ufYHOvr for <quic-issues@ietfa.amsl.com>; Thu, 9 May 2019 11:12:59 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B5EC312006B for <quic-issues@ietf.org>; Thu, 9 May 2019 11:12:58 -0700 (PDT)
Date: Thu, 09 May 2019 11:12:57 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557425577; bh=5JaCg7WkJ7xqGbc/IKOOZN+Iq6heABx0UlQTGnnhbME=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=sz3HbYKBMrQeYZCofy486iOfn8fgVJ6JN6R6CRvfXgzwlEjoJAnxVKSgSrxq3jJnK ZFiW6T03b/Vl30G8vRVavAe02esJUNeQ5uetBsvMObWqYgp011JrRoxP9S74jzWcPs yVfOHMu7znF+zyzYOot/bo9z/xNJ4Myu/WTtCw1g=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2RHUI4TN7HH54KUY524GQCTEVBNHHBUXKDQA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2681/491009691@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2681@github.com>
References: <quicwg/base-drafts/issues/2681@github.com>
Subject: Re: [quicwg/base-drafts] DUPLICATE_PUSH push ID validation (#2681)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd46da9c0b5a_380d3fa2eb0cd960938fe"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/GSockjdDqrJPzWDLQgqh-1uf_JQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 May 2019 18:13:00 -0000

(2) is covered in [Section 5.4](https://quicwg.org/base-drafts/draft-ietf-quic-http.html#server-push):
> Due to reordering, DUPLICATE_PUSH frames or push stream data can arrive before the corresponding PUSH_PROMISE frame. When a client receives a DUPLICATE_PUSH frame for an as-yet-unknown Push ID, the request headers of the push are not immediately available. The client can either delay generating new requests for content referenced following the DUPLICATE_PUSH frame until the request headers become available, or can initiate requests for discovered resources and cancel the requests if the requested resource is already being pushed.

For (1), yes it should -- the DUPLICATE might show up first, but the implication is that the ID has already been used in a PUSH_PROMISE frame.  If that would be invalid, we should be explicit that the DUPLICATE_PUSH is also invalid.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2681#issuecomment-491009691