Re: [quicwg/base-drafts] Fix spelling and style consistency nits (#3946)

[ianswett <[e-mail]>]

@ianswett commented on this pull request.

I agree with Jana that the "ACK Delay" paragraph could use a bit more work, hopefully my suggestions are helpful.

> @@ -3720,11 +3720,11 @@ containing that information is acknowledged.
   unless the endpoint has sent a RESET_STREAM for that stream.  Once an endpoint
   sends a RESET_STREAM frame, no further STREAM frames are needed.
 
-* ACK frames carry the most recent set of acknowledgements and the Ack Delay
-  from the largest acknowledged packet, as described in
-  {{sending-acknowledgements}}. Delaying the transmission of packets
-  containing ACK frames or resending old ACK frames can cause the peer to
-  generate an inflated RTT sample or unnecessarily disable ECN.
+* ACK frames carry the most recent set of acknowledgements and the
+  acknowledgement delay from the largest acknowledged packet, as described in

Ack Delay is the name of the field in the ACK frame, so I thought the old text was correct?

> @@ -5279,13 +5279,14 @@ ACK Delay:
 
 : A variable-length integer representing the time delta in microseconds between
   when the ACK frame was sent and when the largest acknowledged packet, as

```suggestion
  when the largest acknowledged packet, as indicated by the
```

> @@ -5279,13 +5279,14 @@ ACK Delay:
 
 : A variable-length integer representing the time delta in microseconds between
   when the ACK frame was sent and when the largest acknowledged packet, as
-  indicated in the Largest Acknowledged field, was received by this peer.  The
-  value of the ACK Delay field is scaled by multiplying the encoded value by 2
-  to the power of the value of the ack_delay_exponent transport parameter set by
-  the sender of the ACK frame; see {{transport-parameter-definitions}}.  Scaling
-  in this fashion allows for a larger range of values with a shorter encoding at
-  the cost of lower resolution.  Because the receiver doesn't use the ACK Delay
-  for Initial and Handshake packets, a sender SHOULD send a value of 0.
+  indicated in the Largest Acknowledged field, was received by this peer.  This

```suggestion
  Largest Acknowledged field, was received and the ACK frame was sent.  This
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3946#pullrequestreview-456237364