[quicwg/base-drafts] 290a51: Split PTO calculation into a dedicated method

Jana Iyengar <noreply@github.com> Sun, 31 May 2020 02:11 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4B41E3A10D2 for <quic-issues@ietfa.amsl.com>; Sat, 30 May 2020 19:11:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.101
X-Spam-Level:
X-Spam-Status: No, score=-2.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6Ph7jxJKz3BK for <quic-issues@ietfa.amsl.com>; Sat, 30 May 2020 19:11:55 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DDA2D3A10D0 for <quic-issues@ietf.org>; Sat, 30 May 2020 19:11:54 -0700 (PDT)
Received: from github-lowworker-a6a2749.va3-iad.github.net (github-lowworker-a6a2749.va3-iad.github.net [10.48.16.62]) by smtp.github.com (Postfix) with ESMTP id 1FE49A08A8 for <quic-issues@ietf.org>; Sat, 30 May 2020 19:11:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590891114; bh=XKgEjd6fR1tdxWZZhSfKxOnlXgAFUVZpH5K/DFehHAk=; h=Date:From:To:Subject:From; b=mMQ0Gf/X5Z5QvfHzoEzIbJD9x8AsYxiLHHTnWBzrdUmbTYN7kQGuA9cz802jPLs9b IN90XI2e3/VVj4V7Kj7bW1SvzrWp4d9jjFwmS+rdf8MAPXmjHUrUf1IvNMEg3Ewzu7 BtJq3ioiVCdM438cpTDq/cb+ZKlotPrBNAPhZl8M=
Date: Sat, 30 May 2020 19:11:54 -0700
From: Jana Iyengar <noreply@github.com>
To: quic-issues@ietf.org
Message-ID: <quicwg/base-drafts/push/refs/heads/master/72e645-8644f6@github.com>
Subject: [quicwg/base-drafts] 290a51: Split PTO calculation into a dedicated method
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-Auto-Response-Suppress: All
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/GZEOriRyPEP2LkstllRNaaFG6Q4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 31 May 2020 02:11:57 -0000

  Branch: refs/heads/master
  Home:   https://github.com/quicwg/base-drafts
  Commit: 290a5113d74c36b112d3ada80edc2f3ede23325b
      https://github.com/quicwg/base-drafts/commit/290a5113d74c36b112d3ada80edc2f3ede23325b
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-05-20 (Wed, 20 May 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Split PTO calculation into a dedicated method

As @martinthomson pointed out in #3666, it was far too complex and error-prone as-is.

Als fixes #3564 and #3674 by calculating the PTO timeout for each PN space and picking the earliest, as well as checking that there are inflight packets before calculating PTO for a PN space.


  Commit: d0050a08a17463fbf9f3bf25b61b50a982b4a07f
      https://github.com/quicwg/base-drafts/commit/d0050a08a17463fbf9f3bf25b61b50a982b4a07f
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-05-20 (Wed, 20 May 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: 65b036d2c0437e81e0533a76e863bebfaa3207a3
      https://github.com/quicwg/base-drafts/commit/65b036d2c0437e81e0533a76e863bebfaa3207a3
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-05-20 (Wed, 20 May 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: 2630bfdfe743909fb7bd3a92a41bd5f794cc503d
      https://github.com/quicwg/base-drafts/commit/2630bfdfe743909fb7bd3a92a41bd5f794cc503d
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-05-20 (Wed, 20 May 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: 83727ca4f10a4d3866ea026efff3cb833111d1f8
      https://github.com/quicwg/base-drafts/commit/83727ca4f10a4d3866ea026efff3cb833111d1f8
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-05-20 (Wed, 20 May 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: f10875ed05f2edd3fe121631bf89c4a877204fb5
      https://github.com/quicwg/base-drafts/commit/f10875ed05f2edd3fe121631bf89c4a877204fb5
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-05-20 (Wed, 20 May 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Fix errors


  Commit: 242e38d3b7e6170b59b347de6d8b3686af356c11
      https://github.com/quicwg/base-drafts/commit/242e38d3b7e6170b59b347de6d8b3686af356c11
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-05-21 (Thu, 21 May 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Apply suggestions from code review

Co-authored-by: Martin Thomson <mt@lowentropy.net>


  Commit: 7a330219f1b116f3bc1ddbcf8cb8fd8fdd7355b8
      https://github.com/quicwg/base-drafts/commit/7a330219f1b116f3bc1ddbcf8cb8fd8fdd7355b8
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-05-21 (Thu, 21 May 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: 6ce4f9b1841f8f2296e7420b08a928a41f7f2a5a
      https://github.com/quicwg/base-drafts/commit/6ce4f9b1841f8f2296e7420b08a928a41f7f2a5a
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Marten's suggestions


  Commit: 820497e882f930dcdc5d3ae7401add631ec0ea38
      https://github.com/quicwg/base-drafts/commit/820497e882f930dcdc5d3ae7401add631ec0ea38
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-05-28 (Thu, 28 May 2020)

  Changed paths:
    M draft-ietf-quic-http.md
    M draft-ietf-quic-invariants.md
    M draft-ietf-quic-recovery.md
    M draft-ietf-quic-tls.md
    M draft-ietf-quic-transport.md

  Log Message:
  -----------
  Merge branch 'master' into ianswett-split-pto-pseudocode


  Commit: 829501299ef329a19ab52f9f0702a85e144c18a7
      https://github.com/quicwg/base-drafts/commit/829501299ef329a19ab52f9f0702a85e144c18a7
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-05-30 (Sat, 30 May 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Add an assert


  Commit: 92c2e22eaa7bce92d055dba4bf72ecfbc505e5dc
      https://github.com/quicwg/base-drafts/commit/92c2e22eaa7bce92d055dba4bf72ecfbc505e5dc
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-05-30 (Sat, 30 May 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Apply suggestions from code review

Co-authored-by: Jana Iyengar <jri.ietf@gmail.com>


  Commit: 8644f6db1937825ce8162558ea33b135967c3eeb
      https://github.com/quicwg/base-drafts/commit/8644f6db1937825ce8162558ea33b135967c3eeb
  Author: Jana Iyengar <jri.ietf@gmail.com>
  Date:   2020-05-30 (Sat, 30 May 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Merge pull request #3681 from quicwg/ianswett-split-pto-pseudocode

Split PTO calculation into a dedicated method


Compare: https://github.com/quicwg/base-drafts/compare/72e6455c1499...8644f6db1937