Re: [quicwg/base-drafts] Remove requirement for reciprocal connection ID change (#2386)

Jana Iyengar <notifications@github.com> Mon, 04 February 2019 09:13 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7E2FB130E16 for <quic-issues@ietfa.amsl.com>; Mon, 4 Feb 2019 01:13:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.553
X-Spam-Level:
X-Spam-Status: No, score=-12.553 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5yUINqlhcEZl for <quic-issues@ietfa.amsl.com>; Mon, 4 Feb 2019 01:13:46 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7E594130E1C for <quic-issues@ietf.org>; Mon, 4 Feb 2019 01:13:46 -0800 (PST)
Date: Mon, 04 Feb 2019 01:13:45 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549271625; bh=4SnWf0JU2pnz8P8aD2bjSAAMHF0/6OYaCOmrGbsRzmI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ja+Ogc1KTabKrkJltGAor64AK/zz+memWi2aPW+lqR1DU86a1lO4TYSKHOmUYfkzd CwcwdZBTYVKSqqaERcLilU1LEmx9s5KMNQYWaapAU2Ka66fiyC9GU8nLqpSzICSbUN mIohddk0lFwyUJfXk+Wf59ba1oZVf+2Sk0hmvAuo=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8272dc35daaf28f4d2d4186fc5f8b45ab2545cd292cf00000001186fc44992a169ce181d7dce@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2386/review/199487025@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2386@github.com>
References: <quicwg/base-drafts/pull/2386@github.com>
Subject: Re: [quicwg/base-drafts] Remove requirement for reciprocal connection ID change (#2386)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c580249993ee_7f683fa1198d45c4933e7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/GbGJIEhYUy3JGRPz58skCl0fnM4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Feb 2019 09:13:49 -0000

janaiyengar approved this pull request.

A couple of suggestions.

> @@ -2110,19 +2110,10 @@ infrequently.
 
 Endpoints that use connection IDs with length greater than zero could have their
 activity correlated if their peers keep using the same destination connection ID
-after migration. Endpoints that receive packets with a previously unused
-Destination Connection ID SHOULD change to sending packets with a connection ID
-that has not been used on any other network path.  The goal here is to ensure
-that packets sent on different paths cannot be correlated. To fulfill this
-privacy requirement, endpoints that initiate migration and use connection IDs
-with length greater than zero SHOULD provide their peers with new connection IDs
-before migration.
-
-Caution:
-
-: If both endpoints change connection ID in response to seeing a change in
-  connection ID from their peer, then this can trigger an infinite sequence of
-  changes.
+after migration.  The goal is to ensure that packets sent on different

This is a bit awkward. Suggested rewrite:
"after migration. To ensure that packets sent on different paths cannot be correlated, such endpoints SHOULD provide their peers with new connection IDs before migration."

> @@ -2110,19 +2110,10 @@ infrequently.
 
 Endpoints that use connection IDs with length greater than zero could have their

This is not part of your PR, but suggested change: "Endpoints that supply non-zero-length connection IDs ..."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2386#pullrequestreview-199487025