Re: [quicwg/base-drafts] No RTT for non-retransmittable packets (#2078)
ianswett <notifications@github.com> Wed, 05 December 2018 10:42 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 051D8130DDF for <quic-issues@ietfa.amsl.com>; Wed, 5 Dec 2018 02:42:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R_XRQr7kpxal for <quic-issues@ietfa.amsl.com>; Wed, 5 Dec 2018 02:42:24 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 22065130DF9 for <quic-issues@ietf.org>; Wed, 5 Dec 2018 02:42:24 -0800 (PST)
Date: Wed, 05 Dec 2018 02:42:23 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544006543; bh=ZA2gHTF/9526nCF1iMb/+uoMf/5bhqU/wZo+iN7L9tI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0Yv0GavJ/LdcYbjU1u+XqN/9DE7a0RDYCVd+QT0z+OL2v8Zh8sDR/aWq7iVoXthe9 yb7fb0Ju25na7FNix/gdwHnKBs2NOcHCiD9CnwexVbTrNYlk1JJxjrMryiowq4pHY6 U2F333Xs2FUpBcxCZyvNgum5Q3tNHy0RH8FfFxIc=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf9129934b7475767859ebc9369e3a4ac53c86fcf92cf00000001181f6d8f92a169ce17053691@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2078/review/181691408@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2078@github.com>
References: <quicwg/base-drafts/pull/2078@github.com>
Subject: Re: [quicwg/base-drafts] No RTT for non-retransmittable packets (#2078)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c07ab8f70ad2_5b973fc3214d45bc4190cb"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/GcatHXV3fbSbjIMrBgu5x1cisM0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Dec 2018 10:42:26 -0000
ianswett commented on this pull request.
> @@ -284,12 +284,12 @@ frame. For more information, see Section 13.2 of {{QUIC-TRANSPORT}}.
## Computing the RTT estimate
RTT is calculated when an ACK frame arrives by computing the difference between
-the current time and the time the largest newly acked packet was sent. If no
-packets are newly acknowledged, RTT cannot be calculated. When RTT is
-calculated, the ack delay field from the ACK frame SHOULD be subtracted from the
-RTT as long as the result is larger than the Min RTT. If the result is smaller
-than the min_rtt, the RTT should be used, but the ack delay field should be
-ignored.
+the current time and the time the largest acked packet was sent. If the largest
+acked is not newly acknowledged or not retransmittable, RTT cannot be
+calculated. When RTT is calculated, the ack delay field from the ACK frame
Thanks, updated
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2078#discussion_r239013732
- [quicwg/base-drafts] No RTT for non-retransmittab… ianswett
- Re: [quicwg/base-drafts] No RTT for non-retransmi… ianswett
- Re: [quicwg/base-drafts] No RTT for non-retransmi… janaiyengar
- Re: [quicwg/base-drafts] No RTT for non-retransmi… ianswett
- Re: [quicwg/base-drafts] No RTT for non-retransmi… ianswett
- Re: [quicwg/base-drafts] No RTT for non-retransmi… janaiyengar
- Re: [quicwg/base-drafts] No RTT for non-retransmi… janaiyengar