Re: [quicwg/base-drafts] Remove error code and reason phrase from GOAWAY (#355)

Martin Thomson <notifications@github.com> Sun, 05 March 2017 22:56 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 468581294B6 for <quic-issues@ietfa.amsl.com>; Sun, 5 Mar 2017 14:56:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RALAp3OkEywb for <quic-issues@ietfa.amsl.com>; Sun, 5 Mar 2017 14:56:22 -0800 (PST)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AC0831294AE for <quic-issues@ietf.org>; Sun, 5 Mar 2017 14:56:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=7zBo+fYbhRObUsrVK7ulgdzrKoE=; b=J5FsjMDJsyBwGCX+ BxoEb0ZXnkvsy+PY0DoUUfoSP6+q+WW0UHIBxkQXusZCv+E0/TqNYUcLRQy3t56g OzghHgtiW1JXGas+evhzSuXFQfcR3d44anIQ2UAatcKEWettZpT1suUmW5cMQRkE 91T6x2jHkDKFUETeTvbpG4lkZxw=
Received: by filter0947p1mdw1.sendgrid.net with SMTP id filter0947p1mdw1-25064-58BC9795-29 2017-03-05 22:56:21.800245348 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id ITs90G1iRKetSul6hLfBkA for <quic-issues@ietf.org>; Sun, 05 Mar 2017 22:56:21.780 +0000 (UTC)
Date: Sun, 05 Mar 2017 14:56:21 -0800
From: Martin Thomson <notifications@github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/355/review/25159211@github.com>
In-Reply-To: <quicwg/base-drafts/pull/355@github.com>
References: <quicwg/base-drafts/pull/355@github.com>
Subject: Re: [quicwg/base-drafts] Remove error code and reason phrase from GOAWAY (#355)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_58bc9795a6f12_98f3fa8ba359c2c570fc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3laMmLWA4w2VJ9Vj0Is1+7kx//fbB1APSu0c rnWrV1HS2rSmcTZsuNBb1E25qBI3TVbpy2Es4fSjhedsWB5SJHRfoxqepJb61rcAFs2F8fS4PJA9fj foxwAHuFVpyL484oTmodQz+7D/c0XITdHcZj8oWIvaFDFoIiKkuXfNs3F/5MCe4hU5Ku4gHC+qDzd7 o=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Gis_qoNX39-WVPhNL-X3uScYNhY>
Cc: Subscribed <subscribed@noreply.github.com>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.17
Reply-To: quic@ietf.org
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Mar 2017 22:56:24 -0000

martinthomson commented on this pull request.



> +exchanged.  An endpoint MUST set the value of the Last Client or Server Stream
+ID to be at least as high as the highest-numbered stream on which it either sent
+data or received and delivered data to the application protocol that uses QUIC.
+
+An endpoint MAY choose a larger stream identifier if it wishes to allow for a
+number of streams to be created.  This is especially valuable for peer-initiated
+streams where packets creating new streams could be in transit; using a larger
+stream number allows those streams to complete.
+
+In addition to initiating a graceful shutdown of a connection, GOAWAY MAY be
+sent immediately prior to sending a CONNECTION_CLOSE frame that is sent as a
+result of detecting a fatal error.  Higher-numbered streams than those indicated
+in the GOAWAY frame can then be retried.
+
+For peer-initiated streams, an endpoint might indicate a lower value for the
+highest stream number than the value that might be sent by a peer.  After

Actually, now that I think about it, the only reason why you would reduce the largest stream number is because you didn't use those streams, and if you don't want to use those streams, then you can just *not use them*.  Let's remove this paragraph.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/355#discussion_r104327343