IETF Logo Mail Archive

Re: [quicwg/base-drafts] Immediately close with INVALID_TOKEN (#3107)

Martin Thomson <notifications@github.com> Tue, 22 October 2019 04:29 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B6529120058 for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 21:29:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.596
X-Spam-Level:
X-Spam-Status: No, score=-1.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2ArTVpDucgRA for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 21:29:51 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C248A12004F for <quic-issues@ietf.org>; Mon, 21 Oct 2019 21:29:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=TCGGGUX+ToV6gO/cCLcAyuDb0g0=; b=bZ5GU3lx8cce/KcA XSEvi1g64Vm4ZBpEBGyQE8xJHmz3GaEzSfBe9ZY70YOmFMeDPFATsCi1L8lgUTT4 xWlbQVqvIrWE+Ca22JLYcEtJmJlHu/Ed8IPRfDl78lTFiEdKTHjs3iVZFrfRstC7 Ceo47tW12ogiUJCXySIDdjrO3ak=
Received: by filter1913p1mdw1.sendgrid.net with SMTP id filter1913p1mdw1-18808-5DAE7628-16 2019-10-22 03:23:20.884383371 +0000 UTC m=+354614.726225955
Received: from out-13.smtp.github.com (out-13.smtp.github.com [192.30.254.196]) by ismtpd0005p1las1.sendgrid.net (SG) with ESMTP id 4Z0Ny3g-T4mvVgxoJZFBkQ for <quic-issues@ietf.org>; Tue, 22 Oct 2019 03:23:20.729 +0000 (UTC)
Date: Tue, 22 Oct 2019 03:23:20 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6XLH7LBIHI3QEHJKF3XO3LHEVBNHHB4ST4NM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3107/review/304949036@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3107@github.com>
References: <quicwg/base-drafts/pull/3107@github.com>
Subject: Re: [quicwg/base-drafts] Immediately close with INVALID_TOKEN (#3107)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dae76239359_340a3fc6512cd95c1044b7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1eyTek7088YADyYNY6pd1Ghf23w3bmy2OiUX vnzX7Il6dUNyLhIKfJV1ovRfuktHywaybiDi4T9YbtsPvuZpkx6KiYb2jIKdSRvUI1SZeQZggMbbty tTuEqdty8wsZLmSgBXHjHASbwr4XvWMw9pV4I2TFtUf+2ILkd8x1ruTfKt/hqDJbPIMrz240JIspk6 w=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Gj4pjtMMEYmLaW0tyFL7P4a3ptI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 04:29:54 -0000

martinthomson commented on this pull request.



> @@ -1641,6 +1641,14 @@ of connection establishment.  By giving the client a different connection ID to
 use, a server can cause the connection to be routed to a server instance with
 more resources available for new connections.
 
+If a server receives a client Initial with a unverifiable Retry token,
+it knows the client will not accept another Retry token.  It can either
+proceed with the handshake without verifying the token or immediately close

I'm persuaded by Marten's comment here (which I missed at first, I think because we commented at almost the same time).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3107#discussion_r337318870

v2.23.0 | Report a Bug | By Email