Re: [quicwg/base-drafts] Robert Wilton's QPACK Comment 3 (#4802)

Robert Wilton <notifications@github.com> Tue, 26 January 2021 18:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 44A613A0D89 for <quic-issues@ietfa.amsl.com>; Tue, 26 Jan 2021 10:37:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.724
X-Spam-Level:
X-Spam-Status: No, score=-0.724 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=0.726, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EryfLzUMM58P for <quic-issues@ietfa.amsl.com>; Tue, 26 Jan 2021 10:37:08 -0800 (PST)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 941573A0B5B for <quic-issues@ietf.org>; Tue, 26 Jan 2021 10:37:08 -0800 (PST)
Received: from github.com (hubbernetes-node-06a8d25.ac4-iad.github.net [10.52.121.78]) by smtp.github.com (Postfix) with ESMTPA id BCFB5600FE0 for <quic-issues@ietf.org>; Tue, 26 Jan 2021 10:37:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1611686227; bh=6y8JR+EwJ+RjLnKJXGWKhGU4pBy1PtRnUFbSN+/hDuY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=RPOvO+S+GJgWz8ximf/rOh+EswEu8RhR+LZeuUFKUgbAAHAbjLzBdpzhFnx2W38MW Fm1nCtSiTmqu+2aRTtodsdYdChcsctXRQseu+3LEieFHQoK5KMOmPCYVq2rCDz754Q iXswBVO0MS0h1qPq5Bx4NEsdjdlzxNhiuTSYtj7Q=
Date: Tue, 26 Jan 2021 10:37:07 -0800
From: Robert Wilton <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7WG642W6MSTUKJ2SF6DRBFHEVBNHHC6KACPU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/4802/767744393@github.com>
In-Reply-To: <quicwg/base-drafts/issues/4802@github.com>
References: <quicwg/base-drafts/issues/4802@github.com>
Subject: Re: [quicwg/base-drafts] Robert Wilton's QPACK Comment 3 (#4802)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_60106153b8cbe_601a043539b0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: rgwilton
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/GkuL0LUMjhU9iFfGtN22LaZRrOM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jan 2021 18:37:11 -0000

If section 3.2.2 already imposes a limit on the length of an entry, then it would be good to referenced that text from section 7.4.

E.g. section 7.4 states:  `In
   the same way, it has to set a limit to the length it accepts for
   string literals; see Section 4.1.2.`

But I suspect that really the only limit that is needed here is the one in 3.2.2?  I.e. it seems reasonable that a receiver should accept any string up to the maximum table size?

But my other point is that it suggests that a receiver can arbitrarily choose to set a limit on the size of integers that it receives, but section 4.1.1 states: `   QPACK implementations MUST be able to decode integers up to and
   including 62 bits long.`

So, I guess that I'm really suggesting that this paragraph (in section 7.4):

`   An implementation has to set a limit for the values it accepts for
   integers, as well as for the encoded length; see Section 4.1.1.  In
   the same way, it has to set a limit to the length it accepts for
   string literals; see Section 4.1.2.`

is reworded to say something along the lines of:
- Receivers MUST accept integers up to 62 bits long section 4.1.1, but MAY choose to not handle larger integers, in which case they return QPACK_DECOMPRESSION_FAILED.
- Receivers MUST accept any strings up to maximum table length -32, or return QPACK_DECOMPRESSION_FAILED.

It wasn't clear to me whether integers bigger than 62 bits are ever likely in practice, I presume not ...


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/4802#issuecomment-767744393