Date: Sat, 18 Jan 2020 05:35:20 -0800
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKZAEETSB7IES5LD7MV4GA6BREVBNHHCBYLBH4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3361/review/344943800@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3361@github.com>
References: <quicwg/base-drafts/pull/3361@github.com>
Subject: Re: [quicwg/base-drafts] Only send one immediate ACK (#3361)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e230998f0a1c_8843fb51d0cd96c5105f8";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Go_J-jhSyRdlINxeyo2mcBA_40M>


----==_mimepart_5e230998f0a1c_8843fb51d0cd96c5105f8
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

kazuho commented on this pull request.

LGTM modulo one nitpick.

> @@ -3136,12 +3136,10 @@ This recommendation is in keeping with standard practice for TCP {{?RFC5681}}.
 
 In order to assist loss detection at the sender, an endpoint SHOULD send an ACK
 frame immediately on receiving an ack-eliciting packet that is out of order. The
-endpoint MAY continue sending ACK frames immediately on each subsequently
-received packet, but the endpoint SHOULD return to acknowledging every other
-packet within a period of 1/8 x RTT, unless more ack-eliciting packets are
-received out of order.  If every subsequent ack-eliciting packet arrives out of
-order, then an ACK frame SHOULD be sent immediately for every received
-ack-eliciting packet.
+endpoint SHOULD not continue sending ACK frames immediately unless more

not -> NOT

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3361#pullrequestreview-344943800
----==_mimepart_5e230998f0a1c_8843fb51d0cd96c5105f8
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@kazuho</b> commented on this pull request.</p>

<p>LGTM modulo one nitpick.</p><hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3361#discussion_r368227233">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -3136,12 +3136,10 @@ This recommendation is in keeping with standard practice for TCP {{?RFC5681}}.
 
 In order to assist loss detection at the sender, an endpoint SHOULD send an ACK
 frame immediately on receiving an ack-eliciting packet that is out of order. The
-endpoint MAY continue sending ACK frames immediately on each subsequently
-received packet, but the endpoint SHOULD return to acknowledging every other
-packet within a period of 1/8 x RTT, unless more ack-eliciting packets are
-received out of order.  If every subsequent ack-eliciting packet arrives out of
-order, then an ACK frame SHOULD be sent immediately for every received
-ack-eliciting packet.
+endpoint SHOULD not continue sending ACK frames immediately unless more
</pre>
<p>not -&gt; NOT</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3361?email_source=notifications&amp;email_token=AFTOJK4343BYJHJYDDXVMELQ6MARRA5CNFSM4KIONCIKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSHWZOA#pullrequestreview-344943800">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK5F5QOGC2UA7ZWX4VLQ6MARRANCNFSM4KIONCIA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK3TXL6XGX7ACHQOMTDQ6MARRA5CNFSM4KIONCIKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSHWZOA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3361?email_source=notifications\u0026email_token=AFTOJK4343BYJHJYDDXVMELQ6MARRA5CNFSM4KIONCIKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSHWZOA#pullrequestreview-344943800",
"url": "https://github.com/quicwg/base-drafts/pull/3361?email_source=notifications\u0026email_token=AFTOJK4343BYJHJYDDXVMELQ6MARRA5CNFSM4KIONCIKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSHWZOA#pullrequestreview-344943800",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5e230998f0a1c_8843fb51d0cd96c5105f8--