Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)

ianswett <notifications@github.com> Mon, 18 June 2018 15:14 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9EC58130DEA for <quic-issues@ietfa.amsl.com>; Mon, 18 Jun 2018 08:14:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VYmtB2K1ZU2V for <quic-issues@ietfa.amsl.com>; Mon, 18 Jun 2018 08:14:01 -0700 (PDT)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C80AD130DE0 for <quic-issues@ietf.org>; Mon, 18 Jun 2018 08:14:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=fRzLX+uTPD4l8/A3ZjZqF4Qm+U8=; b=N0L1bHfUfABGloSs EzRq1YVbVWug3YrZPWKgPZrlnwOFX8UekSlvzAqpADPNku6Z9FKTSJjl8kCtauz5 M0Xb0+bSsB5a7JmxC0YLZEzRvst0No0uHBGjlurLPKGYgCKyhyMnuq58JdhP7MMV I0BJvza9K0UCnpJK3JhTc69ikMU=
Received: by filter0615p1iad2.sendgrid.net with SMTP id filter0615p1iad2-5024-5B27CC37-14 2018-06-18 15:13:59.442573484 +0000 UTC
Received: from github-lowworker-b40b5a4.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0015p1iad2.sendgrid.net (SG) with ESMTP id THNO_gJNSs2xmyK0TE8aPA for <quic-issues@ietf.org>; Mon, 18 Jun 2018 15:13:59.398 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-b40b5a4.cp1-iad.github.net (Postfix) with ESMTP id 75E5A3E0FDB for <quic-issues@ietf.org>; Mon, 18 Jun 2018 08:13:59 -0700 (PDT)
Date: Mon, 18 Jun 2018 15:13:59 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab98258c48b5a33a696bb0c9d01665595a5b52875592cf00000001173f8e3792a169ce13656182@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1372/review/129608799@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1372@github.com>
References: <quicwg/base-drafts/pull/1372@github.com>
Subject: Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b27cc3772d68_694f2b07f96acf581335a6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2hhLWNcuqoRIULzE1+cNltvyHCjvYtjY9cHv IEZs8BznlQ3YCufSh3Q7o/QAZ7w5V4qSeK+BWhFNEqF1fcak1FCnRUxrjGTnp9DmUMN3e/+vz2AaqC PfOmxWlPpsfQ3qnTwjPN/044JzZ6N1AQkgZsV+QEyfHbu5PGhTN5ut409Q==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/GsFxPtfpDTy0Nl57Z2MVWxSA75M>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jun 2018 15:14:03 -0000

ianswett commented on this pull request.



> @@ -2887,6 +3033,95 @@ by a client in protected packets, because it is certain that the server is able
 to decipher the packet.
 
 
+## ACK_ECN Frame {#frame-ack-ecn}
+
+A QUIC connection MUST keep counters for each ECN codepoint, recording
+the number of packets that were received with the corresponding ECN
+codepoint in the IP header. If the header is not readable from the
+application, the codepoint 00 (Not-ECT) MUST be assumed. If any packet
+are duplicated by the network then only the value of the ECN field of
+the packet copy first received SHALL be included in the counters, the ECN
+field value for a duplicate SHALL be ignored. This to prevent the

I believe the reason TCP counts all CEs is because TCP retransmits packets, not because of an effort to count packets the network inadvertently duplicated.  QUIC does not duplicate packets and instead uses new packet numbes for retransmissions, so I believe this embodies the intent of the requirement.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1372#discussion_r196116256