IETF Logo Mail Archive

Re: [quicwg/base-drafts] Why does stateless reset have to be checked after MAC failure (#2152)

Martin Thomson <notifications@github.com> Wed, 09 October 2019 23:54 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF0DD12004C for <quic-issues@ietfa.amsl.com>; Wed, 9 Oct 2019 16:54:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VaEaeEcOc_Wy for <quic-issues@ietfa.amsl.com>; Wed, 9 Oct 2019 16:54:55 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1CDFC120020 for <quic-issues@ietf.org>; Wed, 9 Oct 2019 16:54:55 -0700 (PDT)
Date: Wed, 09 Oct 2019 16:54:54 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1570665294; bh=JQZHVkWGkuc73er1z7dbAvzo4gDBf0vkeOkLaPKOwGg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SjD/714YLgT7X0FnoEZIz2sZJcazcJ97OhiUxcP6TEuba6iG0iY9x3GhSvmKXKugp iox0Oym+85vtSooRFq/WZyQNef7Sg4M4UggVP8KaOe5vOtgbU1dc0G+NEy1RUba3n3 KyBq9MQA7n7oJEUJyxeY29usuYwyMJKAwAeKifuI=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK473LJQEZPSVGIHHMF3VOS45EVBNHHBOS4WPU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2152/540254372@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2152@github.com>
References: <quicwg/base-drafts/issues/2152@github.com>
Subject: Re: [quicwg/base-drafts] Why does stateless reset have to be checked after MAC failure (#2152)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d9e734e62b37_57d03f88978cd96c6872f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/GtvgwwlIgp0F02PMmJBwmu7p6Ok>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Oct 2019 23:54:57 -0000

Oh, I completely missed the question about ordering in there.  Reading comprehension fail on my part.  I've tweaked the proposed fix to account for this.  Specifically:

> This comparison can be performed for every inbound datagram.  Endpoints MAY skip this check if packets from a datagram are successfully processed.  However, the comparison MUST be performed when the first packet in an incoming datagram either cannot be associated with a connection, cannot be decrypted, or is identified as a duplicate.

Note that I've switched this to datagram rather than packet, so match the sending and to allow for variations in how packets are assembled into datagrams.

I think that fixes it, but I'll wait for input on the new changes before reattaching `proposal-ready`.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2152#issuecomment-540254372

v2.23.0 | Report a Bug | By Email