Re: [quicwg/base-drafts] Rework Retry packet (#1498)
Nick Banks <notifications@github.com> Fri, 29 June 2018 13:30 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 35B7C130E90 for <quic-issues@ietfa.amsl.com>; Fri, 29 Jun 2018 06:30:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nu7MYR1m-_cr for <quic-issues@ietfa.amsl.com>; Fri, 29 Jun 2018 06:30:17 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 53476130E5B for <quic-issues@ietf.org>; Fri, 29 Jun 2018 06:30:17 -0700 (PDT)
Date: Fri, 29 Jun 2018 06:30:16 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530279016; bh=knJD2/qcumAPK5wfdla98RcaSYdKNB+sB/qvL7ErSN8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eD2b5dRerlrhe/bJyXSW37wqrP3fXyMNbd4TBuzgVDOzbzxVsto6RNQ3IAb1cRUOM JGYH5lphBosoyOtALSNyGZjdmjCJ9CRZb/5v5h1xpiC3TjKsrX9dcZCIIIy0eS0LPS AHKdmDebE66HB6Yk4KSkPTch4zgxnf3JR2xhnRTo=
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abca2039903d2fba033aebaf88675184fd9f07907c92cf00000001174df66792a169ce14138c09@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1498/review/133225934@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1498@github.com>
References: <quicwg/base-drafts/pull/1498@github.com>
Subject: Re: [quicwg/base-drafts] Rework Retry packet (#1498)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b363467f3ed3_101f2ae04cd10f5421807d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/HNWhW4ZpDhT1Z6fdFfgXEYfpKPM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jun 2018 13:30:20 -0000
nibanks commented on this pull request. > + +A Retry packet does not include a packet number and cannot be explictly +acknowledged by a client. + +A server MUST only send a Retry in response to a client Initial packet. + +If the Original Destination Connection ID field does not match the Destination +Connection ID from most recent the Initial packet it sent, clients MUST discard +the packet. This prevents an off-path attacker from injecting a Retry packet +with a bogus new Source Connection ID. + +The client responds to a Retry packet with Initial packet that includes the +provided Retry Token to continue connection establishment. + +A server that might send another Retry packet in response to a subsequent +Initial packet MUST set the Source Connection ID to new value of at least 8 They way I read this sentence is that only for additional Retry packets (after the first one) do you need to change the Source CID. But if the server doesn't know that some other middle box (DDoS Mitigation device) has already sent a Retry packet once, then it would likely assume it is the first once to send a Retry packet. Then it might not change the Source CID. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1498#discussion_r199158920
- Re: [quicwg/base-drafts] Rework Retry packet (#14… janaiyengar
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Christian Huitema
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Kazuho Oku
- Re: [quicwg/base-drafts] Rework Retry packet (#14… ekr
- [quicwg/base-drafts] Rework Retry packet (#1498) Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… ekr
- Re: [quicwg/base-drafts] Rework Retry packet (#14… ianswett
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Mike Bishop
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… ianswett
- Re: [quicwg/base-drafts] Rework Retry packet (#14… ianswett
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Christian Huitema
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Mike Bishop
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Mike Bishop
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Marten Seemann
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Christian Huitema
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Marten Seemann
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… MikkelFJ
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Nick Banks
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson
- Re: [quicwg/base-drafts] Rework Retry packet (#14… Martin Thomson