Re: [quicwg/base-drafts] Capitalization and Consistency (PR #4989)

Martin Thomson <notifications@github.com> Tue, 10 May 2022 22:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0D0C0C15949D for <quic-issues@ietfa.amsl.com>; Tue, 10 May 2022 15:48:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.664
X-Spam-Level:
X-Spam-Status: No, score=-3.664 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.575, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dpCBoHORpfU3 for <quic-issues@ietfa.amsl.com>; Tue, 10 May 2022 15:48:18 -0700 (PDT)
Received: from smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6BAA1C14F720 for <quic-issues@ietf.org>; Tue, 10 May 2022 15:48:18 -0700 (PDT)
Received: from github-lowworker-f052de4.va3-iad.github.net (github-lowworker-f052de4.va3-iad.github.net [10.48.109.96]) by smtp.github.com (Postfix) with ESMTP id 4EC415E04D9 for <quic-issues@ietf.org>; Tue, 10 May 2022 15:48:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1652222897; bh=ybvTQzblNi4Kixg0VGE8mXG2kkvW2Hal9dlGSnpIHwo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=fmHGxKynXPHhDsT8QZzQDFr4882Gm4QOQhmHCueW8EzjJt/J9bb0OE8bQZ5FCPtBb hSQ42LMU+cdv+5r707SODB6n12JgRGOSWq9igCoxdDM1A9v4NCJQZqsalhgFbAKPiX MDJtI/f382SeatJh2t/QoncuS8bTUKnFZcgYSXBA=
Date: Tue, 10 May 2022 15:48:17 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5NCL3Q424XF7L6VD6ARAPDDEVBNHHES2CVWA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4989/review/968484859@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4989@github.com>
References: <quicwg/base-drafts/pull/4989@github.com>
Subject: Re: [quicwg/base-drafts] Capitalization and Consistency (PR #4989)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_627aebb140fe6_6a1fd408931d7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/HUtF7OOoe7fbU-LC3Y-1bmYSJv8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.34
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 May 2022 22:48:23 -0000

@martinthomson approved this pull request.

Two small tweaks...maybe.

>  
 This document expands the definition of string literals by permitting them to
 begin other than on a byte boundary.  An "N-bit prefix string literal" begins
 mid-byte, with the first (8-N) bits allocated to a previous field. The string
-uses one bit for the Huffman flag, followed by the Length encoded as a
+uses one bit for the Huffman flag, followed by the string length encoded as a

```suggestion
uses one bit for the Huffman flag, followed by the length of the encoded string as a
```

This blows line length, but maybe this is more precise.

>  
 The value of Base MUST NOT be negative. Though the protocol might operate
-correctly with a negative base using post-base indexing, it is unnecessary and
-inefficient. An endpoint MUST treat a field block with an S bit of 1 as invalid
-if the value of Required Insert Count is less than or equal to the value of
-Delta Base.
+correctly with a negative Base using post-Base indexing, it is unnecessary and
+inefficient. An endpoint MUST treat a field block with a sign bit of 1 as

As a field, is it "sign" or "Sign"?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4989#pullrequestreview-968484859
You are receiving this because you are subscribed to this thread.

Message ID: <quicwg/base-drafts/pull/4989/review/968484859@github.com>