Re: [quicwg/base-drafts] Minor edits to amplification attack text (#1895)
Martin Thomson <notifications@github.com> Sun, 21 October 2018 09:15 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CE74712872C for <quic-issues@ietfa.amsl.com>; Sun, 21 Oct 2018 02:15:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.064
X-Spam-Level:
X-Spam-Status: No, score=-8.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.064, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8Eq8lEeov5Mf for <quic-issues@ietfa.amsl.com>; Sun, 21 Oct 2018 02:15:55 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 182FB127332 for <quic-issues@ietf.org>; Sun, 21 Oct 2018 02:15:54 -0700 (PDT)
Date: Sun, 21 Oct 2018 02:15:54 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540113354; bh=tB/VjiSFVl1Qqtia0Qv/aA3nYifeoET17wcBsQka56w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=lFqg6SlY5CEBPRGXKYijYWmbZMLf/XMKli+FBL66xj/eYMwwVLR3PxtBKO4N1zizp kR8/4HiK3lhlzM67t5Qmjwz2N3fJmdSW/fJwUCF5j2tKUg7BVrrnsem4iOTMDbggya +Im6ub4YN4ac4IjHZ3sgqE5MVQiNBYcA0c523iOs=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2694ca2dae96c5b3dd088d34ef7dfda5c1bbe63392cf0000000117e405ca92a169ce162e64dc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1895/review/166776923@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1895@github.com>
References: <quicwg/base-drafts/pull/1895@github.com>
Subject: Re: [quicwg/base-drafts] Minor edits to amplification attack text (#1895)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bcc43ca29876_11853fd7d00d45c072606b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/HZey57UKxKjMqHmQ3Ca_iD3w9II>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Oct 2018 09:15:57 -0000
martinthomson requested changes on this pull request. Remove that last clause please. > verified through an address validation token (delivered via a Retry packet or -a NEW_TOKEN frame) or by processing any message from the client encrypted using -the Handshake keys. This limit exists to mitigate amplification attacks. +a NEW_TOKEN frame), by processing any message from the client encrypted using +the Handshake keys, or by processing a TLS ClientHello with a valid +pre-shared key. This limit exists to mitigate amplification attacks. This last is not sufficient for address validation. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1895#pullrequestreview-166776923
- [quicwg/base-drafts] Minor edits to amplification… martinduke
- Re: [quicwg/base-drafts] Minor edits to amplifica… ianswett
- Re: [quicwg/base-drafts] Minor edits to amplifica… Marten Seemann
- Re: [quicwg/base-drafts] Minor edits to amplifica… martinduke
- Re: [quicwg/base-drafts] Minor edits to amplifica… Martin Thomson
- Re: [quicwg/base-drafts] Minor edits to amplifica… ianswett
- Re: [quicwg/base-drafts] Minor edits to amplifica… Martin Thomson
- Re: [quicwg/base-drafts] Minor edits to amplifica… ianswett
- Re: [quicwg/base-drafts] Minor edits to amplifica… martinduke
- Re: [quicwg/base-drafts] Minor edits to amplifica… martinduke
- Re: [quicwg/base-drafts] Minor edits to amplifica… martinduke
- Re: [quicwg/base-drafts] Minor edits to amplifica… Martin Thomson
- Re: [quicwg/base-drafts] Minor edits to amplifica… martinduke
- Re: [quicwg/base-drafts] Minor edits to amplifica… Martin Thomson
- Re: [quicwg/base-drafts] Minor edits to amplifica… martinduke
- Re: [quicwg/base-drafts] Minor edits to amplifica… martinduke
- Re: [quicwg/base-drafts] Minor edits to amplifica… Mike Bishop