Re: [quicwg/base-drafts] GOAWAY initiating a graceful shutdown can carry a huge stream ID (#3343)

Martin Thomson <notifications@github.com> Thu, 16 January 2020 03:03 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 60519120803 for <quic-issues@ietfa.amsl.com>; Wed, 15 Jan 2020 19:03:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.455
X-Spam-Level:
X-Spam-Status: No, score=-1.455 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DywF1W4I9fiY for <quic-issues@ietfa.amsl.com>; Wed, 15 Jan 2020 19:03:13 -0800 (PST)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 32ABD12002F for <quic-issues@ietf.org>; Wed, 15 Jan 2020 19:03:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=iKH0QGbP95jZze+mz1O9gIwB4R1MuKM6UikXnUsk2Wo=; b= vlvemEvT/bC3vU+JbcausnyayfS+21ManzC/U6NBThKMXN20xlUP/v98Og8dl3D6 Ffy7TFOYDwzRN9dagyV1MgVjFC6qlklMGaTLHIcJySzYdfQLUAI8McntTrIZVbdf vkjQks7gAfPFqsh8Pnzn3d88Ilq2ihHiulR8NFlg2Nc=
Received: by filter1473p1mdw1.sendgrid.net with SMTP id filter1473p1mdw1-29436-5E1FD270-E 2020-01-16 03:03:12.332255012 +0000 UTC m=+110437.405325888
Received: from github-lowworker-56a5eb2.cp1-iad.github.net (unknown [140.82.115.9]) by ismtpd0054p1iad1.sendgrid.net (SG) with ESMTP id Ju06WuwdTgqyILqbGDEhNA for <quic-issues@ietf.org>; Thu, 16 Jan 2020 03:03:12.283 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-56a5eb2.cp1-iad.github.net (Postfix) with ESMTP id 330F7C007C for <quic-issues@ietf.org>; Wed, 15 Jan 2020 19:03:12 -0800 (PST)
Date: Thu, 16 Jan 2020 03:03:12 +0000 (UTC)
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK77SCXCZNX4ZSKOK554FUCPBEVBNHHCBRUE74@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3343/review/343650000@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3343@github.com>
References: <quicwg/base-drafts/pull/3343@github.com>
Subject: Re: [quicwg/base-drafts] GOAWAY initiating a graceful shutdown can carry a huge stream ID (#3343)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e1fd2703151f_15b43fb8ec4cd96867510"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0IG/VYbCPiq4I9art5gPYHUIJmw3QRahfl0Z rnKiIbVIdlLVmPuRYTIb29299TErxfhqXkOUzWWPjYlB7gHdgrMmrlkBAUJMj6j3dAS60dEA08fj+J GnebWxD8J/4tQ+GbnV0AEA7py9f3FPVmGI6YCQthwOGxDGQZ6q816DG+zZ+UN+DVL029FHdDgej3W4 s=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/H_Iq3fUCEBbPvrEMUIiVn67kI5A>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jan 2020 03:03:15 -0000

martinthomson approved this pull request.

Thanks for taking my comments into consideration.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3343#pullrequestreview-343650000