Re: [quicwg/base-drafts] Scope of disable_active_migration (#3670)

ianswett <notifications@github.com> Tue, 19 May 2020 23:24 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1F8353A00D2 for <quic-issues@ietfa.amsl.com>; Tue, 19 May 2020 16:24:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wK8MmSuvdid0 for <quic-issues@ietfa.amsl.com>; Tue, 19 May 2020 16:24:42 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 566423A00C4 for <quic-issues@ietf.org>; Tue, 19 May 2020 16:24:42 -0700 (PDT)
Received: from github-lowworker-fa7043e.ash1-iad.github.net (github-lowworker-fa7043e.ash1-iad.github.net [10.56.109.45]) by smtp.github.com (Postfix) with ESMTP id 979F56A0DB3 for <quic-issues@ietf.org>; Tue, 19 May 2020 16:24:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589930681; bh=/I0Rl/fa5R5qdQLEyV+nB7mFWnB4VfRI1VFjs+oWLo0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=AC0yFp9MWu/0JF6NKLWrycLKTmcaAUvSfAr3SHsH9+VuP5fxRAt8xKf6vgJ/jPom0 92kPViRk9ndA2KpwMpkLEiYZhpV0jWJLXsq/hqtzWP69G/GAZruuTalHi1k5W37Bc9 IyiDek1gG4PtPHfpN3Q4lrqZtSmw+mNLpE5JBZPo=
Date: Tue, 19 May 2020 16:24:41 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2TZMMI7Q7SUXV2DVV42BF3TEVBNHHCKCGAH4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3670/review/414887843@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3670@github.com>
References: <quicwg/base-drafts/pull/3670@github.com>
Subject: Re: [quicwg/base-drafts] Scope of disable_active_migration (#3670)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ec46ab988ab8_3b223f7e384cd95c133734"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Hb9Nnhu_GELxlLycUhseeQpvWQM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2020 23:24:44 -0000

@ianswett approved this pull request.



> @@ -1229,9 +1229,11 @@ when a client's address changes.
   transport parameter to request that clients move connections to that dedicated
   address. Note that clients could choose not to use the preferred address.
 
-A server in a deployment that does not implement a solution to
-maintain connection continuity during connection migration
-SHOULD disallow migration using the disable_active_migration transport
+A server in a deployment that does not implement a solution to maintain
+connection continuity during connection migration SHOULD disallow migration

```suggestion
connection continuity when the client address changes SHOULD indicate migration is not supported
```

> @@ -1229,9 +1229,11 @@ when a client's address changes.
   transport parameter to request that clients move connections to that dedicated
   address. Note that clients could choose not to use the preferred address.
 
-A server in a deployment that does not implement a solution to
-maintain connection continuity during connection migration
-SHOULD disallow migration using the disable_active_migration transport
+A server in a deployment that does not implement a solution to maintain
+connection continuity during connection migration SHOULD disallow migration
+using the disable_active_migration transport parameter.  The
+disable_active_migration transport parameter does not prohibit subsequent

```suggestion
disable_active_migration transport parameter does not prohibit
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3670#pullrequestreview-414887843