IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add Definitions (#1557)

MikkelFJ <notifications@github.com> Sat, 14 July 2018 19:41 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D96F130EBD for <quic-issues@ietfa.amsl.com>; Sat, 14 Jul 2018 12:41:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JcWkUjYtknsT for <quic-issues@ietfa.amsl.com>; Sat, 14 Jul 2018 12:41:50 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 21591130E98 for <quic-issues@ietf.org>; Sat, 14 Jul 2018 12:41:50 -0700 (PDT)
Date: Sat, 14 Jul 2018 12:41:49 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531597309; bh=0B1d00lhmMfkrZLLWl8lXXx5pptmCuqOUy8PP4PxCyk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=em9oPVnDqIPjSxK8uqIa4Mu1z6raFaRUvpeVhbqazz3XnQcMGdfeSSvzFLKPLZHaK hXXNASzY0W+YM4aIjtPpR0s944AZSBiDqj0e+0uK2C3seBAy9mrFdnF1MVvCD9g7lu d+2lEvD2IVC2DBtkDzETRuYmJX5Qb1Jd5LAY1S+I=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb2a02ed19a3137922e470f96821c19603b0a73f392cf00000001176213fd92a169ce1456e92b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1557/review/137246994@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1557@github.com>
References: <quicwg/base-drafts/pull/1557@github.com>
Subject: Re: [quicwg/base-drafts] Add Definitions (#1557)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4a51fd7983a_6df83f9611476f801409c8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Hj9-WR63xQMRIMM2VYkqJAoUqIk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jul 2018 19:41:52 -0000

mikkelfj commented on this pull request.



>  
 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD",
 "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" in this
 document are to be interpreted as described in BCP 14 {{!RFC2119}} {{!RFC8174}}
 when, and only when, they appear in all capitals, as shown here.
 
+Definitions of terms that are used in this document:
+
+ACK frames:
+
+: ACK frames refer to both ACK and ACK_ECN frames in this
+  document.
+
+ACK-only:
+
+: Any packet containing only an ACK frame.
+

Suggest being specific about ACK and ACK_ECN here

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1557#pullrequestreview-137246994

v2.31.3 | Report a Bug | By Email | System Status