Date: Sat, 14 Jul 2018 12:41:49 -0700
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abb2a02ed19a3137922e470f96821c19603b0a73f392cf00000001176213fd92a169ce1456e92b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1557/review/137246994@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1557@github.com>
References: <quicwg/base-drafts/pull/1557@github.com>
Subject: Re: [quicwg/base-drafts] Add Definitions (#1557)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5b4a51fd7983a_6df83f9611476f801409c8";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Hj9-WR63xQMRIMM2VYkqJAoUqIk>


----==_mimepart_5b4a51fd7983a_6df83f9611476f801409c8
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

mikkelfj commented on this pull request.



>  
 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD",
 "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" in this
 document are to be interpreted as described in BCP 14 {{!RFC2119}} {{!RFC8174}}
 when, and only when, they appear in all capitals, as shown here.
 
+Definitions of terms that are used in this document:
+
+ACK frames:
+
+: ACK frames refer to both ACK and ACK_ECN frames in this
+  document.
+
+ACK-only:
+
+: Any packet containing only an ACK frame.
+

Suggest being specific about ACK and ACK_ECN here

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1557#pullrequestreview-137246994
----==_mimepart_5b4a51fd7983a_6df83f9611476f801409c8
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@mikkelfj</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1557#discussion_r202523681">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt;  
 The key words &quot;MUST&quot;, &quot;MUST NOT&quot;, &quot;REQUIRED&quot;, &quot;SHALL&quot;, &quot;SHALL NOT&quot;, &quot;SHOULD&quot;,
 &quot;SHOULD NOT&quot;, &quot;RECOMMENDED&quot;, &quot;NOT RECOMMENDED&quot;, &quot;MAY&quot;, and &quot;OPTIONAL&quot; in this
 document are to be interpreted as described in BCP 14 {{!RFC2119}} {{!RFC8174}}
 when, and only when, they appear in all capitals, as shown here.
 
+Definitions of terms that are used in this document:
+
+ACK frames:
+
+: ACK frames refer to both ACK and ACK_ECN frames in this
+  document.
+
+ACK-only:
+
+: Any packet containing only an ACK frame.
+
</pre>
<p>Suggest being specific about ACK and ACK_ECN here</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/1557#pullrequestreview-137246994">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkqzE8Px1VGlhgmipwOBqXx2ibPG8lks5uGkl9gaJpZM4VP39p">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq_-tygtX3QUrk0HLh7hvemq2BfMBks5uGkl9gaJpZM4VP39p.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mikkelfj commented on #1557"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1557#pullrequestreview-137246994"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/1557#pullrequestreview-137246994",
"url": "https://github.com/quicwg/base-drafts/pull/1557#pullrequestreview-137246994",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@mikkelfj commented on 1557",
"sections": [
{
"text": "",
"activityTitle": "**MikkelFJ**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@mikkelfj",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1557#pullrequestreview-137246994"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 356482921\n}"
}
],
"themeColor": "26292E"
}
]</script>
----==_mimepart_5b4a51fd7983a_6df83f9611476f801409c8--