Re: [quicwg/base-drafts] Add a maximum for max_ack_delay (#2301)
ianswett <notifications@github.com> Mon, 07 January 2019 03:39 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 81E34129A87 for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 19:39:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vLVMZdAzrBgH for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 19:39:42 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EA0431292F1 for <quic-issues@ietf.org>; Sun, 6 Jan 2019 19:39:41 -0800 (PST)
Date: Sun, 06 Jan 2019 19:39:41 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546832381; bh=RgVlY6xl0LFyr8XZxvmMMfK1gLsjbWQiRWZV8Piftao=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=2JH2rt5Jpb95zH4zu/t0vo2DGnmzzNwLFCtdrayHRbcBRldQ7h4/MAp950O6kSm4V AJSRUsnwgCpd1GfR05MxIhc/3kMEMWaQoxqPPD3ktomlC/VyB9frI38B32VYtR6xVP qEsekSKl457oGaiR91stbOn8+zIvLOBqq5sEc8qk=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba03dedc9239596cea48c3ddf7dad13b9fd28c78e92cf00000001184a8bfd92a169ce179f2f4c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2301/review/189669364@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2301@github.com>
References: <quicwg/base-drafts/pull/2301@github.com>
Subject: Re: [quicwg/base-drafts] Add a maximum for max_ack_delay (#2301)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c32c9fd1744d_5ac93f86686d45c420307a9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/HkWXT3k_JKsyFEZWFf3VYWl9Vj0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jan 2019 03:39:44 -0000
ianswett commented on this pull request. > @@ -4086,6 +4086,7 @@ max_ack_delay (0x000b): delays in alarms firing. For example, if a receiver sets a timer for 5ms and alarms commonly fire up to 1ms late, then it should send a max_ack_delay of 6ms. If this value is absent, a default of 25 milliseconds is assumed. + Values of 2^14 or greater are invalid. Can you clarify what should happen if the value is invalid? ie: Should the receiver cap the value at 2^14 or should the peer close the connection? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2301#pullrequestreview-189669364
- [quicwg/base-drafts] Add a maximum for max_ack_de… Martin Thomson
- Re: [quicwg/base-drafts] Add a maximum for max_ac… Kazuho Oku
- Re: [quicwg/base-drafts] Add a maximum for max_ac… ianswett
- Re: [quicwg/base-drafts] Add a maximum for max_ac… Martin Thomson
- Re: [quicwg/base-drafts] Add a maximum for max_ac… Martin Thomson
- Re: [quicwg/base-drafts] Add a maximum for max_ac… janaiyengar
- Re: [quicwg/base-drafts] Add a maximum for max_ac… ianswett
- Re: [quicwg/base-drafts] Add a maximum for max_ac… ianswett
- Re: [quicwg/base-drafts] Add a maximum for max_ac… Martin Thomson