IETF Logo Mail Archive

Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)

Nick Banks <notifications@github.com> Mon, 25 February 2019 16:39 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EB309130F49 for <quic-issues@ietfa.amsl.com>; Mon, 25 Feb 2019 08:39:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.383
X-Spam-Level:
X-Spam-Status: No, score=-1.383 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qzolDqGLTHvV for <quic-issues@ietfa.amsl.com>; Mon, 25 Feb 2019 08:39:26 -0800 (PST)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1392C130F4D for <quic-issues@ietf.org>; Mon, 25 Feb 2019 08:39:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=0gdZHlshBIgVIfHYPVTK05nGap0=; b=e8tn6wOrqCqwUVWw bJVMPyjkmr7vBit6hyT0Oq9AzHK+/EjqHaBG6pXi056ZhtWnja1w6FFubpZV2JCd l1TkQ6sO3oMie5QN3+U3du4qSlAIIfPKYmzFWcN5M2NkY6ppuRNqSZ4upOCxaDZY ifqgjrsOGd8wjFO5vxubVx4BKyU=
Received: by filter1143p1las1.sendgrid.net with SMTP id filter1143p1las1-19802-5C741A3C-5 2019-02-25 16:39:24.117642388 +0000 UTC m=+316749.000908684
Received: from github-lowworker-05ceafd.cp1-iad.github.net (unknown [192.30.252.40]) by ismtpd0015p1iad2.sendgrid.net (SG) with ESMTP id j6ULinvJS2SMLfgeF1JH3g for <quic-issues@ietf.org>; Mon, 25 Feb 2019 16:39:24.013 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-05ceafd.cp1-iad.github.net (Postfix) with ESMTP id 02A59460CAA for <quic-issues@ietf.org>; Mon, 25 Feb 2019 08:39:24 -0800 (PST)
Date: Mon, 25 Feb 2019 16:39:24 +0000
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba69034a7fe225d4969a1f0b792aa7cdc81b25dd692cf00000001188bdc3b92a169ce17fab1f6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2365/review/207502131@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2365@github.com>
References: <quicwg/base-drafts/pull/2365@github.com>
Subject: Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c741a3ce65_43f73fdb07cd45c092968"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0ZsYcrxxq/m0XWyQo1MOhdAmghBSzbSqhnWH EaGc55QG2ugYJSvl6VNQutcoHC4+C3fviQLU0R9olZ2tOIblwC8luov5iPR+qLwwk5XX7hu7edKvJA 09lbmj2kaGn5oA6vXCNQ7BdA2pu71T/c4lLKfwja93TOMLGK0aMYnxVVB3Se2IBlxHOjE07+RUbZzF U=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/HmBANI10Gw8yVUYMDTkQI-jgrfs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Feb 2019 16:39:36 -0000

nibanks commented on this pull request.



>     OnPacketsLost(lost_packets):
      // Remove lost packets from bytes_in_flight.
      for (lost_packet : lost_packets):
        bytes_in_flight -= lost_packet.size
-     largest_lost_packet = lost_packets.last()
+     newest_lost_packet = lost_packets.last()

Fine with me. I might look at changing it later.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2365#discussion_r259912200

v2.23.0 | Report a Bug | By Email