Re: [quicwg/base-drafts] Reword Immediate ACK Recommendation (#2424)

ianswett <notifications@github.com> Mon, 11 February 2019 20:28 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A72ED131198 for <quic-issues@ietfa.amsl.com>; Mon, 11 Feb 2019 12:28:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VYu5NEVPOVnq for <quic-issues@ietfa.amsl.com>; Mon, 11 Feb 2019 12:27:58 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 70760131193 for <quic-issues@ietf.org>; Mon, 11 Feb 2019 12:27:58 -0800 (PST)
Date: Mon, 11 Feb 2019 12:27:57 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549916877; bh=OH2kAX7qA0HYW9sxNIUbkTKYeDS3rQYwDSRoqNNISUI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=jJPeMD//QdxWFZJ7zkCMGFm5xm7ZsXlC3xveEYSD0dGn/HK9S6M7EkaSvtpx2r/JU N/5cbK6CG3j2vzI3yA9OJ79jgXyi2s1L7blO6wR35F23lvPZfMMxCWKskticc73HU5 mhBcm6VlNE0Y9CBQxh0nyT9o8sC3fSn9fqgmprs4=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abdde3210aa67e9289dbdefa254c64e9b6992f9d3992cf0000000118799ccd92a169ce1842c3b7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2424/review/202320362@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2424@github.com>
References: <quicwg/base-drafts/pull/2424@github.com>
Subject: Re: [quicwg/base-drafts] Reword Immediate ACK Recommendation (#2424)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c61dacd3dec5_1bc63fa25b4d45bc507ee"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/HpjF0v5_2EcBU9Y-k5rzaYMIGCA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Feb 2019 20:28:01 -0000

ianswett commented on this pull request.

I'm confused about what problem you're trying to fix with the immediate ACK text.  Can you clarify?

> @@ -135,6 +135,12 @@ Crypto Packets:
 : Packets containing CRYPTO data sent in Initial or Handshake
   packets.
 
+Out-of-order Packets:
+
+: Packets that do not increase the largest received packet number for its
+packet number space by exactly one. Packets usually arrive out of order

Duplication doesn't count as out-of-order because the packet is ignored.  Misbehaving senders are certainly possible, but I'm not sure how important they are to this text?

> @@ -244,11 +250,11 @@ ack-eliciting packet. QUIC recovery algorithms do not assume the peer sends
 an ACK immediately when receiving a second ack-eliciting packet.
 
 In order to accelerate loss recovery and reduce timeouts, the receiver SHOULD
-send an immediate ACK when it receives a new packet which is not one greater
-than the largest received packet number. A receiver MAY send immediate ACKs
-for the next few ack-eliciting packets that are received, but SHOULD NOT
-send an immediate ACK for more than 1/8 RTT after receiving an out-of-order
-packet.
+send immediate ACKs for an interval after it receives an out-of-order packet.
+This interval SHOULD be between zero (immediately acking only out-of-order

I'm finding this increasingly hard to read.  Can we pop the stack and you can explain what's unclear about the existing text?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2424#pullrequestreview-202320362