Re: [quicwg/base-drafts] Crypto cleanup (#1476)
Mike Bishop <notifications@github.com> Tue, 26 June 2018 20:44 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BA91B130ED2 for <quic-issues@ietfa.amsl.com>; Tue, 26 Jun 2018 13:44:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VQLkh1PULl5g for <quic-issues@ietfa.amsl.com>; Tue, 26 Jun 2018 13:44:47 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CBF50130ECB for <quic-issues@ietf.org>; Tue, 26 Jun 2018 13:44:46 -0700 (PDT)
Date: Tue, 26 Jun 2018 13:44:46 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530045886; bh=5UU8cEI7m/XHqtF0dzqZP4lZ+4F2/gp2I3yLBbwYPwo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=VSmkmD8qFK4HmQrFuMCoPPJf8pva5pH53qahLsj7O++GRU5pf78WoannkufnFwTZr dXY6WhGSOndCVu9JHIFAzrAQz3se1CcUN2Vb/53JK8I4riUuOECUCdmZu3iH1LH8U7 4KOad7zqltkPMjmpQVFPz0iQGTAEWo/Nk9uBWCcM=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abdcf8ea780d67cf4327ae84fe84865d1c544c42b792cf00000001174a67be92a169ce14012f6b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1476/review/132194801@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1476@github.com>
References: <quicwg/base-drafts/pull/1476@github.com>
Subject: Re: [quicwg/base-drafts] Crypto cleanup (#1476)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b32a5be2c6d5_4a392ad01e36ef5c306816"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Hstp90XZab33xykJL0CfmUnUMLE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jun 2018 20:44:49 -0000
MikeBishop approved this pull request. +1 to Jana's suggestion to merge this quickly. A reflow without any text changes, I would probably just have committed directly to master. It will break any open PRs that aren't already bitrotten, so do it quickly before there are any. > @@ -255,11 +252,11 @@ than 1.25 * max(SRTT, latest_RTT) since when it was sent. Using max(SRTT, latest_RTT) protects from the two following cases: * the latest RTT sample is lower than the SRTT, perhaps due to reordering where -packet whose ack triggered the Early Retransit process encountered a shorter -path; + packet whose ack triggered the Early Retransit process encountered a shorter **the** packet > ### Crypto Handshake Timeout -Data in CRYPTO_HS frames is critical to QUIC transport and crypto negotiation, -so a more aggressive timeout is used to retransmit it. Below, the word -handshake packet is used to refer to packets containing CRYPTO_HS frames, -not packets with the specific long header packet type Handshake. +Data in CRYPTO frames is critical to QUIC transport and crypto negotiation, so a +more aggressive timeout is used to retransmit it. Below, the word handshake +packet is used to refer to packets containing CRYPTO frames, not packets with (Unmodified text, but you touch it, you own it.) "handshake packet" isn't actually *a* word. Perhaps "the term," and put "handshake packet" in quotes to designate it as the term you're discussing for clarity? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1476#pullrequestreview-132194801
- Re: [quicwg/base-drafts] Crypto cleanup (#1476) Martin Thomson
- Re: [quicwg/base-drafts] Crypto cleanup (#1476) Martin Thomson
- Re: [quicwg/base-drafts] Crypto cleanup (#1476) Martin Thomson
- Re: [quicwg/base-drafts] Crypto cleanup (#1476) Mike Bishop
- Re: [quicwg/base-drafts] Crypto cleanup (#1476) janaiyengar
- Re: [quicwg/base-drafts] Crypto cleanup (#1476) janaiyengar
- Re: [quicwg/base-drafts] Crypto cleanup (#1476) Christopher Wood
- Re: [quicwg/base-drafts] Crypto cleanup (#1476) ianswett
- Re: [quicwg/base-drafts] Crypto cleanup (#1476) Nick Banks
- Re: [quicwg/base-drafts] Crypto cleanup (#1476) MikkelFJ
- Re: [quicwg/base-drafts] Crypto cleanup (#1476) Christopher Wood
- Re: [quicwg/base-drafts] Crypto cleanup (#1476) Martin Thomson
- [quicwg/base-drafts] Crypto cleanup (#1476) Martin Thomson
- Re: [quicwg/base-drafts] Crypto cleanup (#1476) ekr
- Re: [quicwg/base-drafts] Crypto cleanup (#1476) ianswett