Date: Mon, 14 Aug 2017 19:17:15 +0000 (UTC)
From: Subodh Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab164e412b297883ae044a670d876ac9db8663daec92cf0000000115a9b93a92a169ce0ee8a0bd@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/730@github.com>
Subject: [quicwg/base-drafts] Change design and and FIN to flow control (#730)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5991f73a9fc85_4c5c3fd473f7fc384012b";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/HtWXu70ZS4z_pMAOCACxdnqEe3U>

----==_mimepart_5991f73a9fc85_4c5c3fd473f7fc384012b
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

This PR has 1 editorial change and 2 design changes to flow control:

* [editorial] Clarifies the language around stream and connection flow control and makes it match the flow control section. 

* [design] Defines flow control in terms of offsets instead of max data. This means something different, because previously, maxData = 10 indicated that you could only send offset till 9, however with the change, sending maxOffset = 10 means that you can send offset until 10, i.e. 11 bytes. We could alternatively change the language of maxOffset to be MUST be LESS than instead of MUST NOT EXCEED to match maximumData.

* [design]  Makes FIN bit to be flow controllable. This would reduce one edge case where a packet scheduler does not have to do a special check for whether it only needs to send a FIN when it checks for flow control. This has the advantage of being able to define flow control on a stream in terms of offsets rather than max data.
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/730

-- Commit Summary --

  * Clarify and and FIN to flow control

-- File Changes --

    M draft-ietf-quic-transport.md (31)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/730.patch
https://github.com/quicwg/base-drafts/pull/730.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/730

----==_mimepart_5991f73a9fc85_4c5c3fd473f7fc384012b
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p>This PR has 1 editorial change and 2 design changes to flow control:</p>
<ul>
<li>
<p>[editorial] Clarifies the language around stream and connection flow control and makes it match the flow control section.</p>
</li>
<li>
<p>[design] Defines flow control in terms of offsets instead of max data. This means something different, because previously, maxData = 10 indicated that you could only send offset till 9, however with the change, sending maxOffset = 10 means that you can send offset until 10, i.e. 11 bytes. We could alternatively change the language of maxOffset to be MUST be LESS than instead of MUST NOT EXCEED to match maximumData.</p>
</li>
<li>
<p>[design]  Makes FIN bit to be flow controllable. This would reduce one edge case where a packet scheduler does not have to do a special check for whether it only needs to send a FIN when it checks for flow control. This has the advantage of being able to define flow control on a stream in terms of offsets rather than max data.</p>
</li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>&nbsp;&nbsp;<a href='https://github.com/quicwg/base-drafts/pull/730'>https://github.com/quicwg/base-drafts/pull/730</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Clarify and and FIN to flow control</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/quicwg/base-drafts/pull/730/files#diff-0">draft-ietf-quic-transport.md</a>
    (31)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/quicwg/base-drafts/pull/730.patch'>https://github.com/quicwg/base-drafts/pull/730.patch</a></li>
  <li><a href='https://github.com/quicwg/base-drafts/pull/730.diff'>https://github.com/quicwg/base-drafts/pull/730.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/730">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq1y4GUVdoZ7xfCSK9auJum9FZwnwks5sYJ06gaJpZM4O2yDB">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AWbkqxXRi9-Cc0BNnT3rxQ4f80yzmWpSks5sYJ06gaJpZM4O2yDB.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/quicwg/base-drafts/pull/730"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Change design and and FIN to flow control (#730)"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/730"}}}</script>

----==_mimepart_5991f73a9fc85_4c5c3fd473f7fc384012b--