IETF Logo Mail Archive

[quicwg/base-drafts] Make lint faster (#938)

Mike Bishop <notifications@github.com> Thu, 16 November 2017 10:22 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 61A91120046 for <quic-issues@ietfa.amsl.com>; Thu, 16 Nov 2017 02:22:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.799
X-Spam-Level:
X-Spam-Status: No, score=-4.799 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id teTzIdncCrzD for <quic-issues@ietfa.amsl.com>; Thu, 16 Nov 2017 02:22:37 -0800 (PST)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A652C1270AE for <quic-issues@ietf.org>; Thu, 16 Nov 2017 02:22:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=mo/pQJboWg5D+WsVGB8qVBk6O4w=; b=QFC2PI10iOx2wm23 lUBT0vshFSMb+X6VSIjAyNDd289Gl7YRH6+poBNreR9lq3mPyDCMAqwbThsaWkKx JuxQU2hxisIMtnDctJHcQhnThvfibeG1xhZt38zXBBXqz2DvV6cHzAwDPAsG+7El W2+hA49FAV+utc0qtMJS8wJy9ag=
Received: by filter0230p1iad2.sendgrid.net with SMTP id filter0230p1iad2-2089-5A0D66EB-15 2017-11-16 10:22:35.431151508 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id ZAmmh9cLQZuZ9cYl2l0QDw for <quic-issues@ietf.org>; Thu, 16 Nov 2017 10:22:35.311 +0000 (UTC)
Date: Thu, 16 Nov 2017 10:22:35 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6b4bb1b10a97f21404e5cc0ea3d062ea47c9411092cf00000001162528eb92a169ce105bfce4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/938@github.com>
Subject: [quicwg/base-drafts] Make lint faster (#938)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5a0d66eb39ede_69183fd141a50f30180883"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
tracking:
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0ogqw1gfkhaWeRZeAZdC1e5dbc//jnHsw5aj uV3InmdzOLFFKls60dPFC5LiOFbn63aJbXtvad2X+EexPHORnEbWsInMDTaI24tOKropeFuBlCxeKL K8Q7ucmwfx4kRRRJ0li+JqfDlAgs3vwlSw1Vd0y5qmcmSEtxDv8WTzadMvp6vo9wj7JumKT5gSECYn c=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/I33Obv2TRnS9bwJ_nSkRelm1qVU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Nov 2017 10:22:39 -0000

Ian and I were remarking that makes and commits have gotten very slow lately.  Some observation of my machine shows that I'm spending twelve seconds checking for trailing whitespace and long lines.

This updates the `make lint` recipe to cache the hashes per branch of files that have successfully been linted and not re-lint them unless they've been modified.  On my machine, lint goes from 12 seconds to 0.75 seconds.
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/938

-- Commit Summary --

  * Make lint faster

-- File Changes --

    M .gitignore (1)
    M Makefile (39)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/938.patch
https://github.com/quicwg/base-drafts/pull/938.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/938

v2.30.2 | Report a Bug | By Email | System Status