Re: [quicwg/base-drafts] Tolerate unknown stream types, add greasing (#1525)
Martin Thomson <notifications@github.com> Fri, 06 July 2018 00:00 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 24EC3130DDB for <quic-issues@ietfa.amsl.com>; Thu, 5 Jul 2018 17:00:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id esUkc-hGSLpa for <quic-issues@ietfa.amsl.com>; Thu, 5 Jul 2018 17:00:44 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DAC5A130E22 for <quic-issues@ietf.org>; Thu, 5 Jul 2018 17:00:41 -0700 (PDT)
Date: Thu, 05 Jul 2018 17:00:40 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530835240; bh=kPsLU0gUhy+ipZV8AnSh+BTx9CzEBv7u0l21FUi1g14=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TqpgU+gsAn9ig/LKr4CLTZuaYIP2NXPW7GpT2muqSkpbe9jHp0+TQJP21CuDnAxqx O726FYRMZ2THUts8xYZhCAyl/o42w8mCLHXoakD0ctzRyaPC/kKDu00DVShpQuKByE qNfLohpq2rc288O55CScoDCyfkwsDGFWKflVbE0g=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab02c5058c772e3d3c33f736aa3ae5a9b5d80ac86e92cf000000011756732892a169ce142f90e7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1525/review/134853553@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1525@github.com>
References: <quicwg/base-drafts/pull/1525@github.com>
Subject: Re: [quicwg/base-drafts] Tolerate unknown stream types, add greasing (#1525)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b3eb128c3fd3_2a993fd0ef054f889569e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/IAExLZ6O4ypHCLpa0aUST1TFLmQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jul 2018 00:00:49 -0000
martinthomson approved this pull request.
Seems reasonable to me.
> unknown. Implementations SHOULD NOT send stream types the peer is not already
-known to support, since a stream error can be promoted to a connection error at
-the peer's discretion (see {{errors}}).
+known to support. Recipients of unknown stream types MAY trigger a QUIC
+STOP_SENDING frame with an error code of HTTP_UNKNOWN_STREAM_TYPE, but MUST NOT
+consider such streams to be an error of any kind.
You might want to point out that these cannot include QPACK header blocks unless that is explicitly negotiated.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1525#pullrequestreview-134853553
- Re: [quicwg/base-drafts] Tolerate unknown stream … Lucas Pardue
- Re: [quicwg/base-drafts] Tolerate unknown stream … Lucas Pardue
- Re: [quicwg/base-drafts] Tolerate unknown stream … Mike Bishop
- Re: [quicwg/base-drafts] Tolerate unknown stream … Mike Bishop
- Re: [quicwg/base-drafts] Tolerate unknown stream … Mike Bishop
- Re: [quicwg/base-drafts] Tolerate unknown stream … Mike Bishop
- Re: [quicwg/base-drafts] Tolerate unknown stream … Lucas Pardue
- Re: [quicwg/base-drafts] Tolerate unknown stream … Lucas Pardue
- Re: [quicwg/base-drafts] Tolerate unknown stream … Mike Bishop
- Re: [quicwg/base-drafts] Tolerate unknown stream … janaiyengar
- Re: [quicwg/base-drafts] Tolerate unknown stream … Mike Bishop
- Re: [quicwg/base-drafts] Tolerate unknown stream … Martin Thomson
- Re: [quicwg/base-drafts] Tolerate unknown stream … Martin Thomson
- Re: [quicwg/base-drafts] Tolerate unknown stream … Mike Bishop
- Re: [quicwg/base-drafts] Tolerate unknown stream … Lucas Pardue
- Re: [quicwg/base-drafts] Tolerate unknown stream … Mike Bishop
- [quicwg/base-drafts] Tolerate unknown stream type… Mike Bishop
- Re: [quicwg/base-drafts] Tolerate unknown stream … Martin Thomson