Re: [quicwg/base-drafts] Do not allow ICMP PTB to increase PMTU (#2161)
Igor Lubashev <notifications@github.com> Fri, 14 December 2018 14:55 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DB5831288BD for <quic-issues@ietfa.amsl.com>; Fri, 14 Dec 2018 06:55:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.056
X-Spam-Level:
X-Spam-Status: No, score=-8.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id elwOHq4PlPgt for <quic-issues@ietfa.amsl.com>; Fri, 14 Dec 2018 06:55:43 -0800 (PST)
Received: from out-12.smtp.github.com (out-12.smtp.github.com [192.30.254.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A3CFB128A6E for <quic-issues@ietf.org>; Fri, 14 Dec 2018 06:55:43 -0800 (PST)
Date: Fri, 14 Dec 2018 06:55:42 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544799342; bh=mABk2M09ZLEcZoaUZSv5j6wIzSQQM7UHMXkTtbyN/Xc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=freIL7NGygzNZOZtfVaCjzby3coRKjcgLr1GzEiS0fWhD9/iKkRCYhLbPFgI4Esh7 f3YZNCyNpFhKGgqbgF0/ojtJIoo+YlW4tYuJzYvq5AU8N2iZ8AtleftBAAqlPpfB7q leVvMKo4U3oXZBURwNacBfsMuSUrR75KIH0MEQO0=
From: Igor Lubashev <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab647b14ace7857b398a00752a22fca6ee1581221592cf00000001182b866e92a169ce174c2f88@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2161/review/185142807@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2161@github.com>
References: <quicwg/base-drafts/pull/2161@github.com>
Subject: Re: [quicwg/base-drafts] Do not allow ICMP PTB to increase PMTU (#2161)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c13c46eb50db_45ab3fb1ad8d45c0199087"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: igorlord
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/IBukd2fNWxZaYQT_BwRXQ2untCk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Dec 2018 14:55:46 -0000
igorlord commented on this pull request. > @@ -3139,7 +3139,8 @@ attacks that successfully guess the IP address 3-tuple and reduce the PMTU to a bandwidth-inefficient value. An endpoint MUST ignore an ICMP message that claims the PMTU has decreased below -1280 bytes. +1280 bytes. And endpoint MUST ignore an ICMP message that attempts to increase +PMTU, unless the ICMP message was received in response to a PMTU probe packet. See the note above where I was wondering if people would read it the way you did. The "unless" part only cancels "ignore the message" instruction. It does not recommend using the message's MTU as PMTU w/o probing it first. I did not want to get into PLDPMTUD probe size selection details, but, yet, you were confused by the text, so I will add a few more words... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2161#discussion_r241780513
- [quicwg/base-drafts] Do not allow ICMP PTB to inc… Igor Lubashev
- Re: [quicwg/base-drafts] Do not allow ICMP PTB to… Igor Lubashev
- Re: [quicwg/base-drafts] Do not allow ICMP PTB to… Martin Thomson
- Re: [quicwg/base-drafts] Do not allow ICMP PTB to… Igor Lubashev
- Re: [quicwg/base-drafts] Do not allow ICMP PTB to… Gorry Fairhurst
- Re: [quicwg/base-drafts] Do not allow ICMP PTB to… Magnus Westerlund
- Re: [quicwg/base-drafts] Do not allow ICMP PTB to… Gorry Fairhurst
- Re: [quicwg/base-drafts] Do not allow ICMP PTB to… Igor Lubashev
- Re: [quicwg/base-drafts] Do not allow ICMP PTB to… Igor Lubashev
- Re: [quicwg/base-drafts] Do not allow ICMP PTB to… Igor Lubashev
- Re: [quicwg/base-drafts] Do not allow ICMP PTB to… Igor Lubashev
- Re: [quicwg/base-drafts] Do not allow ICMP PTB to… Martin Thomson
- Re: [quicwg/base-drafts] Do not allow ICMP PTB to… Magnus Westerlund
- Re: [quicwg/base-drafts] Do not allow ICMP PTB to… ianswett
- Re: [quicwg/base-drafts] Do not allow ICMP PTB to… Martin Thomson