Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rather than CRYPTO_CLOSE (#1477)
ianswett <notifications@github.com> Tue, 26 June 2018 13:04 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9DC1E130DDF for <quic-issues@ietfa.amsl.com>; Tue, 26 Jun 2018 06:04:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yBggzVAGExN3 for <quic-issues@ietfa.amsl.com>; Tue, 26 Jun 2018 06:04:08 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 471B01294D7 for <quic-issues@ietf.org>; Tue, 26 Jun 2018 06:04:08 -0700 (PDT)
Date: Tue, 26 Jun 2018 06:04:07 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530018247; bh=ClCkuxc9t0Hxdyt8S5qKJhEk4H6R1t+TJuwi8zb0x14=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ZyVT7cmxrQHQ8MwS/osHGAzwn/wWHPDYl6WRcSoLDdijbowXHFZQBpBaJLBDwkWMD k9NAKqQcucg/mEMK8XM/IJIq+iQfMKJtGCLbw83NWSjEw7xLfyrfujx1g93e7OECTq LbBseauwnQFUbBxGVtW+HH3dfKbCWwoeWRIKLhNM=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4012312dab0f8a07b7b6b13862a6933b18123f4092cf000000011749fbc792a169ce14014295@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1477/review/131980571@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1477@github.com>
References: <quicwg/base-drafts/pull/1477@github.com>
Subject: Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rather than CRYPTO_CLOSE (#1477)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b3239c74a384_46e32af470598f5030788e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/IIfrLlVkjuTOb8Ks2e-ECjPjvk0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jun 2018 13:04:11 -0000
ianswett approved this pull request. Some small nits, but mostly looks good to me. > @@ -1032,7 +1032,6 @@ explained in more detail as they are referenced later in the document. | 0x0f | PATH_RESPONSE | {{frame-path-response}} | | 0x10 - 0x17 | STREAM | {{frame-stream}} | | 0x18 | CRYPTO_HS | {{frame-crypto}} | -| 0x19 | CRYPTO_CLOSE | {{frame-crypto-close}} | | 0x20 | NEW_TOKEN | {{frame-new-token}} | Renumber NEW_TOKEN to 0x19 > Application protocols can signal application-specific protocol errors using the APPLICATION_CLOSE frame. Errors that are specific to the transport, including all those described in this document, are carried in a CONNECTION_CLOSE frame. Other than the type of error code they carry, these frames are identical in format and semantics. -A CONNECTION_CLOSE, CRYPTO_CLOSE, or APPLICATION_CLOSE frame could be -sent in a packet that is lost. An endpoint SHOULD be prepared to -retransmit a packet containing either frame type if it receives more -packets on a terminated connection. Limiting the number of -retransmissions and the time over which this final packet is sent +A CONNECTION_CLOSE, or APPLICATION_CLOSE frame could be sent in a packet that is "," unnecessary -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1477#pullrequestreview-131980571
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Martin Thomson
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Martin Thomson
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Martin Thomson
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Martin Thomson
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Mike Bishop
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… janaiyengar
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Nick Banks
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… ianswett
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Rui Paulo
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Martin Thomson
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… Martin Thomson
- Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rat… ekr
- [quicwg/base-drafts] Use CONNECTION_CLOSE rather … Martin Thomson