IETF Logo Mail Archive

Re: [quicwg/base-drafts] Reword Immediate ACK Recommendation (#2424)

Nick Banks <notifications@github.com> Mon, 11 February 2019 21:25 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AF46E126C15 for <quic-issues@ietfa.amsl.com>; Mon, 11 Feb 2019 13:25:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iOCR5dVIC_vH for <quic-issues@ietfa.amsl.com>; Mon, 11 Feb 2019 13:25:41 -0800 (PST)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5FDB3126D00 for <quic-issues@ietf.org>; Mon, 11 Feb 2019 13:25:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=rbl8de50M8HMhVqAPL6Wq7BmzuI=; b=qTvdjivEwIJXgNkc NWBQ1WhkPlvwR7slP7RX1W86gzrhOBZs1Cn9XqLUXHyTuBkawVc+jyfD2dh1wqCj ykDtrV31W+8VmWU9X6cbNFQbnbI8m+5U05seEYVTzeEgHEkkTKVe3SYLuO1Ezg0w EE3Pj1b+17W3XjoORYLLJjcpg9k=
Received: by filter0734p1las1.sendgrid.net with SMTP id filter0734p1las1-24700-5C61E854-22 2019-02-11 21:25:40.549544365 +0000 UTC m=+275762.681027223
Received: from github-lowworker-39ccb07.cp1-iad.github.net (unknown [192.30.252.40]) by ismtpd0002p1iad2.sendgrid.net (SG) with ESMTP id M6rRRYIMRZqqRpKhbNwoyQ for <quic-issues@ietf.org>; Mon, 11 Feb 2019 21:25:40.577 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-39ccb07.cp1-iad.github.net (Postfix) with ESMTP id 6D58B400AFC for <quic-issues@ietf.org>; Mon, 11 Feb 2019 13:25:40 -0800 (PST)
Date: Mon, 11 Feb 2019 21:25:40 +0000
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba80c0ee2b631ff6b65ee71e798a1ba2abf7fd9df92cf000000011879aa5492a169ce1842c3b7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2424/review/202345314@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2424@github.com>
References: <quicwg/base-drafts/pull/2424@github.com>
Subject: Re: [quicwg/base-drafts] Reword Immediate ACK Recommendation (#2424)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c61e8546b05c_17423fe8148d45b4321248"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0zydqkofazRh3hqJLoO8tcn6LDybHsUgghiN Qgj4O1nfKo1JZLJcHwG17sgAsjE8FSr3htzUOR8Q/gQBsoIFZv51s0AH2FuigrogCKxxCpITTk7m5U 7CwMXPbPCeaivmcEVY7trgUlf14xwUcuGKUHZhwMF+WtyMqXDOPH+gvKX+w+DX/rNonkZwxmNrqumM Q=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/INdbcZpaYL6-4W-WuVMWCc3xCkI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Feb 2019 21:25:44 -0000

nibanks approved this pull request.

LGTM

> @@ -135,6 +135,12 @@ Crypto Packets:
 : Packets containing CRYPTO data sent in Initial or Handshake
   packets.
 
+Out-of-order Packets:
+
+: Packets that do not increase the largest received packet number for its
+  packet number space by exactly one. Packets arrive out of order
+  when earlier packets are lost or delayed.

 I don't know... I think it might read better with 'earlier' included. I don't think it's confusing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2424#pullrequestreview-202345314

v2.23.0 | Report a Bug | By Email