Re: [quicwg/base-drafts] HTTP: make few minor stylistic improvements (#2127)

Mike Bishop <notifications@github.com> Wed, 12 December 2018 17:41 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3185B1277BB for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 09:41:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.46
X-Spam-Level:
X-Spam-Status: No, score=-4.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mpjJ7aKbgIG4 for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 09:41:37 -0800 (PST)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 18C38130E4F for <quic-issues@ietf.org>; Wed, 12 Dec 2018 09:41:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=6Uq4UTOZjOkAZZG4R8Dgksi0tRc=; b=S0HvrQkThyKCVHh5 3M8ukSKYaD770b6a9GvAhsBY40BHX2acNiNF4rfDBx8HZLhgwPvn+aQkIICKQIlp +XdFlw2wyzHyEjggaJl4PGBr9FsN23B3yH0XaGJ1OLCRwW9CJuvnFYsOaPWeo4Mn hPR5MJZRP7w8B2/ihFcse/DDd7U=
Received: by filter0244p1iad2.sendgrid.net with SMTP id filter0244p1iad2-19180-5C11484C-3 2018-12-12 17:41:32.039636879 +0000 UTC m=+151806.268335367
Received: from github-lowworker-c7d2ff2.cp1-iad.github.net (unknown [192.30.252.32]) by ismtpd0013p1iad2.sendgrid.net (SG) with ESMTP id Ks95DOHKSLWeaNx3eqtsTw for <quic-issues@ietf.org>; Wed, 12 Dec 2018 17:41:32.005 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-c7d2ff2.cp1-iad.github.net (Postfix) with ESMTP id E97994C0352 for <quic-issues@ietf.org>; Wed, 12 Dec 2018 09:41:31 -0800 (PST)
Date: Wed, 12 Dec 2018 17:41:32 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab933dac04fc8f92e879086296d05df6ab7702242c92cf0000000118290a4b92a169ce174367c2@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2127/review/184306313@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2127@github.com>
References: <quicwg/base-drafts/pull/2127@github.com>
Subject: Re: [quicwg/base-drafts] HTTP: make few minor stylistic improvements (#2127)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c11484be73c7_2a513f8ee9ad45b424476a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0+Sm1lGr0FkdooYFCDCYrPCofsvh0LAybODT IAjaNtIXK6Jp3Dphf7L0crJchfmG9DMCDUl1Hk/cYjfFQC3y8BwTFJZIMqeIZNnh1VxzXvXo/h0I3+ vuFUuhJ78Tip3XgwlmuC/PwaXz7hBoUPgzFV3CqsqiRje0WVPePW9op9MmqCv0WP3JTHeseuNObcXa o=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/IQYbnhbnGEgMerRQaJohagGUREg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Dec 2018 17:41:39 -0000

MikeBishop commented on this pull request.

I'm fine with the removal of the "However," but I'm not convinced the other two are improvements.

> @@ -1079,9 +1079,9 @@ priority.
 ### Placeholders
 
 In HTTP/2, certain implementations used closed or unused streams as placeholders
-in describing the relative priority of requests.  However, this created
-confusion as servers could not reliably identify which elements of the priority
-tree could safely be discarded. Clients could potentially reference closed
+in describing the relative priority of requests.  This created
+confusion as servers could not identify reliably which elements of the priority

I think this is placed correctly, and I feel like the change reads awkwardly.

> @@ -1079,9 +1079,9 @@ priority.
 ### Placeholders
 
 In HTTP/2, certain implementations used closed or unused streams as placeholders
-in describing the relative priority of requests.  However, this created
-confusion as servers could not reliably identify which elements of the priority
-tree could safely be discarded. Clients could potentially reference closed
+in describing the relative priority of requests.  This created
+confusion as servers could not identify reliably which elements of the priority
+tree could be safely discarded. Clients could potentially reference closed

I think you're right that this ought to move, but I think "could be discarded safely" reads better than either.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2127#pullrequestreview-184306313