Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CA1F71202B9 for ; Wed, 27 Mar 2019 06:03:25 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -8.001 X-Spam-Level: X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TQbV8bJ3gyNQ for ; Wed, 27 Mar 2019 06:03:24 -0700 (PDT) Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CF18C1202AF for ; Wed, 27 Mar 2019 06:03:23 -0700 (PDT) Date: Wed, 27 Mar 2019 06:03:22 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1553691802; bh=WgbsUgmhAMiKiTApvWpj+L6Va3DKmeAYLtiXsG77N+w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Te2SwrWAmPDnGbPF5RKUenNv5lHUaqIX/fw8vAWYmSdcZQ8K6IdCjQHYK3DI4GHxA uNguKJKH/m1wl2S5BkmKpV29C/uqXVhd4rXdpLWt5IS9OXGGtI3yCzK1UppKdXB1Z7 Dx8hy88J/OCpm71B25X1GDkKjniRAgUuN99pjAhg= From: Jana Iyengar Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] Transport parameters are mandatory. Fixes #2528 (#2560) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c9b749a80d16_740e3f85ae6d45c0312380"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: janaiyengar X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Mar 2019 13:03:26 -0000 ----==_mimepart_5c9b749a80d16_740e3f85ae6d45c0312380 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit janaiyengar commented on this pull request. > @@ -1249,7 +1249,11 @@ quic_transport_parameters extension carries a TransportParameters struct when the version of QUIC defined in {{QUIC-TRANSPORT}} is used. The quic_transport_parameters extension is carried in the ClientHello and the -EncryptedExtensions messages during the handshake. +EncryptedExtensions messages during the handshake. Endpoints MUST send the +quic_transport_parameters extension; endpoints that receive ClientHello or +EncryptedExtensions messages without the quic_transport_parameters extension +MUST terminate the TLS handshake with a fatal missing_extension alert (an error ```suggestion MUST close the connection with an error of type 0x16d (equivalent to a fatal TLS missing_extension alert, see Section {{tls-errors}}). ``` > @@ -1258,8 +1262,8 @@ parameters will cause the handshake to fail. Endpoints MUST NOT send this extension in a TLS connection that does not use QUIC (such as the use of TLS with TCP defined in {{!TLS13}}). A fatal -unsupported_extension alert MUST be sent if this extension is received when the -transport is not QUIC. +unsupported_extension alert (an error of 0x16e) MUST be sent if this extension +is received when the transport is not QUIC. This is not just in your text, but while you're here, also replace the text with: "The connection MUST be closed with an error code of type 0x16e (equivalent to a fatal TLS unsupported_extension alert, see Section {{tls-errors}}) if the transport is not QUIC." -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2560#pullrequestreview-219440815 ----==_mimepart_5c9b749a80d16_740e3f85ae6d45c0312380 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

@janaiyengar commented on this pull request.

=0D =0D
=0D =0D

In draft-ietf-quic-tls.md:

=0D 
> @@ -1249,7 +1249,11 @@ quic_transport_para=
meters extension carries a TransportParameters struct when=0D
 the version of QUIC defined in {{QUIC-TRANSPORT}} is used.=0D
 =0D
 The quic_transport_parameters extension is carried in the ClientHello an=
d the=0D
-EncryptedExtensions messages during the handshake.=0D
+EncryptedExtensions messages during the handshake. Endpoints MUST send t=
he=0D
+quic_transport_parameters extension; endpoints that receive ClientHello =
or=0D
+EncryptedExtensions messages without the quic_transport_parameters exten=
sion=0D
+MUST terminate the TLS handshake with a fatal missing_extension alert (a=
n error=0D
=0D =E2=AC=87=EF=B8=8F Suggested change=0D 
-MUST terminate the TLS handshake with a fatal=
 missing_extension alert (an error=0D
+MUST close the connection with an error of type 0x16d (equivalent to a f=
atal TLS missing_extension alert, see Section {{tls-errors}}).=0D
=0D =0D =0D
=0D =0D

In draft-ietf-quic-tls.md:

=0D 
> @@ -1258,8 +1262,8 @@ parameters will caus=
e the handshake to fail.=0D
 =0D
 Endpoints MUST NOT send this extension in a TLS connection that does not=
 use=0D
 QUIC (such as the use of TLS with TCP defined in {{!TLS13}}).  A fatal=0D=

-unsupported_extension alert MUST be sent if this extension is received w=
hen the=0D
-transport is not QUIC.=0D
+unsupported_extension alert (an error of 0x16e) MUST be sent if this ext=
ension=0D
+is received when the transport is not QUIC.=0D
=0D

This is not just in your text, but while you're here, also replace the= text with:
=0D "The connection MUST be closed with an error code of type 0x16e (equivale= nt to a fatal TLS unsupported_extension alert, see Section {{tls-errors}}= ) if the transport is not QUIC."

=0D =0D

&m= dash;
You are receiving this because you are subscribed to this thre= ad.
Reply to this email directly, view it on GitHub, or mute the thread.

= =0D =0D = ----==_mimepart_5c9b749a80d16_740e3f85ae6d45c0312380--