Re: [quicwg/base-drafts] Transport error codes would be smaller and more consistent as a varint (#2672)

Martin Thomson <notifications@github.com> Tue, 07 May 2019 23:50 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A46A7120073 for <quic-issues@ietfa.amsl.com>; Tue, 7 May 2019 16:50:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.918
X-Spam-Level:
X-Spam-Status: No, score=-1.918 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yjkk0Z7f5gud for <quic-issues@ietfa.amsl.com>; Tue, 7 May 2019 16:50:04 -0700 (PDT)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7C7881200CD for <quic-issues@ietf.org>; Tue, 7 May 2019 16:50:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=DUb3JEYO/Y0EWfrmcNlAbF1Werc=; b=uhk/NRnC8IRk9tJb 98/bO3iW2XciGtA2hxgv+iuQr6VAZV3f1xJAq+F0ZMVj5uLpPXItI4r5SemRX48Y PYMfYS5I4WQ+X9qNZbvTwUYGjpTJcsM9wRqrL55dIrQvFPBeTxRMgvC71s9il3AH VACmEhyuRHtheDcpHjIY5d9dU9k=
Received: by filter0312p1iad2.sendgrid.net with SMTP id filter0312p1iad2-3101-5CD219A8-1E 2019-05-07 23:50:00.881294567 +0000 UTC m=+5962.282626543
Received: from github-lowworker-1c220e1.cp1-iad.github.net (unknown [140.82.115.0]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id Ge9WyyQ8Rkyp2Uo9DDfHUQ for <quic-issues@ietf.org>; Tue, 07 May 2019 23:50:00.821 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1c220e1.cp1-iad.github.net (Postfix) with ESMTP id BB98B1607C0 for <quic-issues@ietf.org>; Tue, 7 May 2019 16:50:00 -0700 (PDT)
Date: Tue, 07 May 2019 23:50:01 +0000 (UTC)
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6QXUMCNOROMLHNR4V235GCREVBNHHBUT5QOM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2672/490294758@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2672@github.com>
References: <quicwg/base-drafts/issues/2672@github.com>
Subject: Re: [quicwg/base-drafts] Transport error codes would be smaller and more consistent as a varint (#2672)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd219a8b8af4_a333faaa9ecd96416612a"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3cnZBCZGpWhQPD/sZcghZfIMDoL0ot9H3q/h TF3Klf4s/RTLkyNySHiosgS0aU257vqE0+BLQKjjuGwufRAEUeQhEAt/SbCjDFNvtLS1QOyt/pd/Ea f3UYVLfuu3MTaI1IjoUi6fS8sF8qY1VMx5Dt1ALGs5kqxkOfYvF/KbFrqDSyIqcLOFCwddvwlfwZyG g=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ISeD8S9n4shVzjQK_y8q3paymaE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 May 2019 23:50:07 -0000

I'm of the opinion that varint is OK.  We can crib text from other varint usages about IANA registries and such, so the change is cheap for the spec perspective.

The HTTP_MALFORMED_FRAME thing would need a solution.  I've never been a big fan of the concept, but anything would do (apart from the 2^60 thing, which would take 1/4 of the entire space for bad frames, which is excessive; I hope that's just an error).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2672#issuecomment-490294758