Re: [quicwg/base-drafts] ACK-only packets are not congestion controlled (#3453)

Jana Iyengar <notifications@github.com> Fri, 28 February 2020 00:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 192BA3A0A8F for <quic-issues@ietfa.amsl.com>; Thu, 27 Feb 2020 16:49:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level:
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A5PBPBv6TCsk for <quic-issues@ietfa.amsl.com>; Thu, 27 Feb 2020 16:49:31 -0800 (PST)
Received: from out-13.smtp.github.com (out-13.smtp.github.com [192.30.254.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DE5CD3A0A6E for <quic-issues@ietf.org>; Thu, 27 Feb 2020 16:49:28 -0800 (PST)
Received: from github-lowworker-2e54e43.va3-iad.github.net (github-lowworker-2e54e43.va3-iad.github.net [10.48.17.27]) by smtp.github.com (Postfix) with ESMTP id 7D80D261663 for <quic-issues@ietf.org>; Thu, 27 Feb 2020 16:49:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582850968; bh=KX546W7kNWeyLcli7cdllQyk8L9u0OewXfOx9kVCK3c=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=VQqDM91B+K6o/DY4lvuHXueDYkH/R2qjmHmVJXzsG3VmZ0FbfFQqHeMjT/XTMRwCf Frg96CxESIFfnMW3HhCmdiEuJvru0Ank7iNG8j962XWp1U6ZnlyG7wg2wI+36nNOoa ZZ0gMSB+eChuw7cBKN6pWtUH/NsQdiieVOEFuTAY=
Date: Thu, 27 Feb 2020 16:49:28 -0800
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3I6XBSN6TWSWTMDCF4MWLBREVBNHHCDI3TA4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3453/review/366098714@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3453@github.com>
References: <quicwg/base-drafts/pull/3453@github.com>
Subject: Re: [quicwg/base-drafts] ACK-only packets are not congestion controlled (#3453)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e586398381b8_35473fd95f8cd96c12537e"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/IW8ykiU3M1cznJ64eU93cNeBJi0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Feb 2020 00:49:32 -0000

janaiyengar approved this pull request.



> @@ -643,6 +643,12 @@ If an endpoint uses a different controller than that specified in this document,
 the chosen controller MUST conform to the congestion control guidelines
 specified in Section 3.1 of {{!RFC8085}}.
 
+Similar to TCP, Packets only containing ACK frames do not count towards bytes

```suggestion
Similar to TCP, packets containing only ACK frames do not count towards bytes
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3453#pullrequestreview-366098714