Re: [quicwg/base-drafts] Placeholders for PRIORITY (#1422)
Martin Thomson <notifications@github.com> Fri, 08 June 2018 13:39 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B1A2E130EA6 for <quic-issues@ietfa.amsl.com>; Fri, 8 Jun 2018 06:39:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YpkxZSX4iPHH for <quic-issues@ietfa.amsl.com>; Fri, 8 Jun 2018 06:39:25 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B15F5130EA3 for <quic-issues@ietf.org>; Fri, 8 Jun 2018 06:39:25 -0700 (PDT)
Date: Fri, 08 Jun 2018 06:39:25 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1528465165; bh=IPjnA+OrurlaA/cnpt5EQc0oGUstqFKUYgLqaCECXMk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eYNPqZzj2DU6QLTLqqUsQ3elL3rXPXgk/m7RA5EWY82zA7KlifRwBpU4SwiWvzgx6 MT2mnTMHjToHxJDBpfP3Jfwhcg+ZnYcPJ3X9zmf6Ej/MF5WuX7IvJQe3JTeGpCtx3o KQeLo3sC8DgwHPGsPLH9bry0zqSI0/l6L3S9Ccqc=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba9f7e1b31935ed8d608e9a852da22f00f85be7b192cf000000011732490d92a169ce13aba9f8@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1422/review/127164641@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1422@github.com>
References: <quicwg/base-drafts/pull/1422@github.com>
Subject: Re: [quicwg/base-drafts] Placeholders for PRIORITY (#1422)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b1a870df8b0_29313ffba1b88f8028229"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/I_F-Aa2JT0yZvMeIkeZCgOsb30Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jun 2018 13:39:28 -0000
martinthomson commented on this pull request. This looks broadly OK, but I wonder if we can't exploit the properties of stream identifiers to our advantage here. Stream ID modulo 4 of a request stream will always be 0. That leaves 3/4 of the entire space of identifiers available to us. Maybe we could drop the dependency and priority types and encode the type in the last octets of the "stream ID": * 00 is a request stream (it happens to also match the stream ID) * 11 is a push stream, identified by push ID shifted left by 2 (this might result in the push ID matching the push stream ID, which might be confusing, so we might choose not to use this) * 01 is a placeholder * 10 is the root (and we would reserve/prohibit values other than 0 for the remaining bits of the identifier) Then the only bit remaining in the flags is the Exclusive bit. You could also use a flag for the root and omit the dependency identifier in that case, leaving the odd single-valued encoding untouched. It seems like we'd have plenty of space in the flags if that was what was wanted. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1422#pullrequestreview-127164641
- Re: [quicwg/base-drafts] Placeholders for PRIORIT… Mike Bishop
- Re: [quicwg/base-drafts] Placeholders for PRIORIT… Mike Bishop
- Re: [quicwg/base-drafts] Placeholders for PRIORIT… Martin Thomson
- Re: [quicwg/base-drafts] Placeholders for PRIORIT… Mike Bishop
- [quicwg/base-drafts] Placeholders for PRIORITY (#… Mike Bishop
- Re: [quicwg/base-drafts] Placeholders for PRIORIT… Martin Thomson
- Re: [quicwg/base-drafts] Placeholders for PRIORIT… Mike Bishop
- Re: [quicwg/base-drafts] Placeholders for PRIORIT… Mike Bishop