IETF Logo Mail Archive

Re: [quicwg/base-drafts] Duplicates are dropped (#1624)

ianswett <notifications@github.com> Tue, 07 August 2018 18:34 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 017E2130EE4 for <quic-issues@ietfa.amsl.com>; Tue, 7 Aug 2018 11:34:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DorxmycOKQWu for <quic-issues@ietfa.amsl.com>; Tue, 7 Aug 2018 11:34:46 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1249C130E42 for <quic-issues@ietf.org>; Tue, 7 Aug 2018 11:34:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=IqpW+UV+3UluNhqO2Fc/ysiU8AU=; b=cdPBj9FZSPvury3i 9+9x6cmBL9vOg+STHhLt3OTxoog9XW8k7yx6vEZx6/8SiSY7i69gqnGiSAUyWhnQ KVKmyc3rA5cIF978tI3lmMHn7Yf62xzBqMXFprXD209oncIakqpaFx5mi6PzN4SV pA4NTwO/4Gg35G1QX766+nD3RDo=
Received: by filter1219p1las1.sendgrid.net with SMTP id filter1219p1las1-19386-5B69E642-38 2018-08-07 18:34:43.012340892 +0000 UTC m=+1109188.646569546
Received: from github-lowworker-e51511d.cp1-iad.github.net (unknown [192.30.252.34]) by ismtpd0001p1iad2.sendgrid.net (SG) with ESMTP id GcvLcjOYRyK2jSnKn8jiNA for <quic-issues@ietf.org>; Tue, 07 Aug 2018 18:34:42.930 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e51511d.cp1-iad.github.net (Postfix) with ESMTP id E0D7180BE3 for <quic-issues@ietf.org>; Tue, 7 Aug 2018 11:34:42 -0700 (PDT)
Date: Tue, 07 Aug 2018 18:34:43 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb7fe307620fe6c917d940ce4f0af2df60da0002492cf000000011781a84292a169ce14a685b4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1624/review/144129346@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1624@github.com>
References: <quicwg/base-drafts/pull/1624@github.com>
Subject: Re: [quicwg/base-drafts] Duplicates are dropped (#1624)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b69e642df57e_3ee63fe5e84d45b418052e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2R49mhkxlmJujsjGe8BP92wHF9zFY7ldicBk mP6DVcHTZ/Jbujbf+7dI1Jvg6gnwADInX1tlzpk5Z56Y1cwsPIa904u13kNLXCf2ZLPx0JFXC3633O xQ38u65blzyjWezWL+h514F5xc5cv30+1SMJKR6wh7HUcGwaSOag8bf4EYCUX8bVQ5hoTQQsoA7khF Q=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/IcTGxm8xSEyVvEsNHiJ1WG2W8DI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Aug 2018 18:34:48 -0000

ianswett commented on this pull request.



> @@ -1065,6 +1066,13 @@ sending a packet with a number of 0x6b2d79 requires a packet number encoding
 with 14 bits or more; whereas the 30-bit packet number encoding is needed to
 send a packet with a number of 0x6bc107.
 
+An endpoint MUST discard packets with duplicate packet numbers.  After

How about combining the first two sentences, since they seem largely redundant? Maybe "An endpoint MUST discard packets with duplicate packet numbers after unprotecting the packet." or something similar.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1624#pullrequestreview-144129346

v2.26.15 | Report a Bug | By Email | System Status